VACMS-19227: Adds Philippines as a US state for facility purposes

[omahane]

Description

Relates to #19227

Testing done

Manually
Cypress (regression)

Screenshots

QA steps

Set up QA Content Publisher user

• Log in as an admin
• Assign the following roles to QA Content Publisher
  • Content creator - VAMC
  • Content publisher
• Assign the following Section to QA Content Publisher
  • VISN 21

Add Philippines as a state to facilities

• As an admin, edit Manila VA Clinic
• Choose "Philippines" under State
• Save the node as published
• Edit VA Regional Benefit Office at U.S. Embassy in Manila
• Save as draft

Create an event

• Log in as QA Content Publisher
• Make an event in the VA Manila Clinic Section
• Add an address for the location that is in the Philippines
• Save the node
• Confirm that it saves without error
• Confirm that the state is identified as "PH"

Set the location for facilities

• Log in as an admin
• Go to the Manila VA Clinic
• Set the state as "Philippines"
• Save the node
• Confirm that it saves without error
• Confirm that the state is identified as "PH"
• Go to the VA Regional Benefit Office at U.S. Embassy in Manila
• Set the state as "Philippines"
• Save the node
• Confirm that it saves without error
• Confirm that the state is identified as "PH"

Create a news release

• Log in as QA Content Publisher
• Create a new release
• Confirm that Philippines is available as a State
• Fill out all required fields
• Save the release as draft
• Confirm that the node saves without error
• Confirm that "PH" is present in the saved release on node:view

Edit a pre-existing news release

• Go to the list of content in your section.
• Filter for a news release
• Edit the release
• Confirm that the address is still in the US
• Save the node
• Confirm that the node saves without error
• Confirm that the US is present in the saved release on node:view

Regression tests

• Creating content with a non-Philippines state
  • Cypress
    • Event
    • Press release

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[omahane]

@edmund-dunn @dsasser I have a change in this PR that replaces the default states in the US with a list that includes the Philippines, as we have facilities in the Philippines that are mapped to US addresses by way of the Lighthouse API:

Do you think it makes more sense to keep it in the va_gov_manila module because it's only necessary because of the Manila facilities? Or do you think that the scope of the change makes it necessary to add to a module that encompasses more features, such as va_gov_facilities or va_gov_backend?

[github-actions]

Checking composer.lock changes...

[omahane]

Do you think it makes more sense to keep it in the va_gov_manila module because it's only necessary because of the Manila facilities? Or do you think that the scope of the change makes it necessary to add to a module that encompasses more features, such as va_gov_facilities or va_gov_backend?

Based on the conversation on Slack, I chose to create a new module and add the code to that: https://dsva.slack.com/archives/CT4GZBM8F/p1733844761259909

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[dsasser]

Looks like possibly a rebase may have caused some things to get added to this PR that are not expected. See other comments.

[github-actions]

Checking composer.lock changes...

[github-actions]

The number of lines changed in composer.lock exceeds the acceptable threshold.

• Lines changed: 8
• Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

[github-actions]

Checking composer.lock changes...

[github-actions]

Checking composer.lock changes...

[dsasser]

Great work. Code changes are awesome and the QA steps passed. Philippines is now available for all addresses across the CMS!

[github-actions]

Checking composer.lock changes...

[va-cms-bot]

Cypress Accessibility Violations

/test-data-facilis

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
  Impact: critical
  Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"

• HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
  Impact: critical
  Target: button[data-proofing-help-title="About 'Main content' field"]
  Summary: Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role="none" or role="presentation"