VACMS-19227: Philippines in the US for facility addresses #20067

omahane · 2024-12-09T21:58:15Z

Description

Relates to #19227

Testing done

Manually

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

Do this
- Validate that
Then
- Validate that
Then validate Acceptance Criteria from issue
- a
- b
- c

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

github-actions · 2024-12-09T21:58:37Z

Checking composer.lock changes...

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

PHP_CodeSniffer

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'LA'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 204 in 8c42577

'id' => 'LA'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'ME'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 210 in 8c42577

'id' => 'ME'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MH'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 216 in 8c42577

'id' => 'MH'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MD'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 222 in 8c42577

'id' => 'MD'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MA'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 228 in 8c42577

'id' => 'MA'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MI'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 234 in 8c42577

'id' => 'MI'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'FM'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 240 in 8c42577

'id' => 'FM'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MN'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 246 in 8c42577

'id' => 'MN'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MS'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 252 in 8c42577

'id' => 'MS'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MO'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 258 in 8c42577

'id' => 'MO'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MT'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 264 in 8c42577

'id' => 'MT'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NE'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 270 in 8c42577

'id' => 'NE'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NV'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 276 in 8c42577

'id' => 'NV'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NH'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 282 in 8c42577

'id' => 'NH'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NJ'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 288 in 8c42577

'id' => 'NJ'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NM'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 294 in 8c42577

'id' => 'NM'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NY'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 300 in 8c42577

'id' => 'NY'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'NC'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 306 in 8c42577

'id' => 'NC'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'ND'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 312 in 8c42577

'id' => 'ND'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'MP'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 318 in 8c42577

'id' => 'MP'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'OH'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 324 in 8c42577

'id' => 'OH'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'OK'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 330 in 8c42577

'id' => 'OK'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'OR'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 336 in 8c42577

'id' => 'OR'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'PW'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 342 in 8c42577

'id' => 'PW'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'PA'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 348 in 8c42577

'id' => 'PA'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'PH'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 354 in 8c42577

'id' => 'PH'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'PR'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 361 in 8c42577

'id' => 'PR'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'RI'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 367 in 8c42577

'id' => 'RI'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'SC'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 373 in 8c42577

'id' => 'SC'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'SD'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 379 in 8c42577

'id' => 'SD'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'TN'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 385 in 8c42577

'id' => 'TN'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'TX'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 391 in 8c42577

'id' => 'TX'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'UT'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 397 in 8c42577

'id' => 'UT'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'VT'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 403 in 8c42577

'id' => 'VT'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'VI'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 409 in 8c42577

'id' => 'VI'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'VA'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 415 in 8c42577

'id' => 'VA'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'WA'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 421 in 8c42577

'id' => 'WA'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'WV'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 427 in 8c42577

'id' => 'WV'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'WI'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 433 in 8c42577

'id' => 'WI'

⚠️ [PHP_CodeSniffer] <Drupal.Arrays.Array.CommaLastItem> _{reported by reviewdog 🐶}
A comma should follow the last multiline array item. Found: 'WY'

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 439 in 8c42577

'id' => 'WY'

🚫 [PHP_CodeSniffer] <Squiz.WhiteSpace.FunctionSpacing.AfterLast> _{reported by reviewdog 🐶}
Expected 1 blank line after function; 0 found

va.gov-cms/docroot/modules/custom/va_gov_manila/src/EventSubscriber/ManilaAddPhilippinesStateSubscriber.php

Line 444 in 8c42577

}

github-actions · 2024-12-09T22:04:55Z

GitHub Workflows (.github/workflows/*.yml)

Have you...

pinned all affected GitHub Actions at a specific commit by SHA?
reviewed the source code of the action at the commit you are pinning?
confirmed that no GitHub security measures are being bypassed?
checked for any injection of user content into protected contexts?
reviewed Security hardening for GitHub Actions?
reviewed GitHub Workflows?

github-actions · 2024-12-09T22:04:56Z

Checking composer.lock changes...

…t political ones

github-actions · 2024-12-09T22:10:20Z

Checking composer.lock changes...

omahane · 2024-12-09T22:15:36Z

Wrong commit

omahane requested review from a team as code owners December 9, 2024 21:58

va-cms-bot temporarily deployed to Tugboat December 9, 2024 21:58 Destroyed

github-actions bot reviewed Dec 9, 2024

View reviewed changes

omahane force-pushed the VACMS-19227-philippines-in-US branch from 8c42577 to 5266fc9 Compare December 9, 2024 22:04

va-cms-bot had a problem deploying to Tugboat December 9, 2024 22:04 Error

davidmpickett and others added 12 commits December 9, 2024 16:09

Update staff profile & vamc b&i

bd13113

VAMC facility mental health

4edbfde

fix truncated confirmation message

9d90a29

reverting previous change & removing empty fieldset

f401aa6

finish reverting SCSS change

8fdfe40

SCSS updates to phone number paragraph

dc9331d

adding ids for specificity

10e21ae

what about twig

3a5ba36

Rolling back CSS and Twig. Adding fieldset wrapping

126ec70

VACMS-19512: Updates SCSS for clarity and DS alignment

7d15f04

VACMS-19512: Updates test for phone widget

102bae3

VACMS-19227: Adds Philippines as a US state for facility purposes, no…

1f1875b

…t political ones

omahane force-pushed the VACMS-19227-philippines-in-US branch from 5266fc9 to 1f1875b Compare December 9, 2024 22:09

va-cms-bot temporarily deployed to Tugboat December 9, 2024 22:10 Destroyed

omahane closed this Dec 9, 2024

omahane deleted the VACMS-19227-philippines-in-US branch December 9, 2024 22:15

mmiddaugh mentioned this pull request Jan 2, 2025

Drupal support for international locations #20193

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-19227: Philippines in the US for facility addresses #20067

VACMS-19227: Philippines in the US for facility addresses #20067

omahane commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot left a comment

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

omahane commented Dec 9, 2024

VACMS-19227: Philippines in the US for facility addresses #20067

VACMS-19227: Philippines in the US for facility addresses #20067

Conversation

omahane commented Dec 9, 2024

Description

Testing done

Screenshots

QA steps

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

github-actions bot commented Dec 9, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

GitHub Workflows (.github/workflows/*.yml)

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

omahane commented Dec 9, 2024