Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19814: Update npm dependencies #20025

Conversation

keisterj-oddball
Copy link
Collaborator

@keisterj-oddball keisterj-oddball commented Dec 4, 2024

Description

Closes #19814.

Testing done

  1. Tested scripts in the root package.json
  2. Ensure cypress commands work locally as well as in tugboat

Screenshots

QA steps

What needs to be checked to prove this works?

  • The javascript for the CMS should build successfully, and cypress tests should pass in tugboat.

What needs to be checked to prove it didn't break any related things?

  • Cypress tests should pass as expected in tugboat.

Definition of Done

  • Automated tests have passed.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

Copy link

github-actions bot commented Dec 4, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2024 20:10 Destroyed
Copy link

github-actions bot commented Dec 4, 2024

Checking composer.lock changes...

@keisterj-oddball keisterj-oddball changed the title Updated node to 22.11.0 VACMS-19814: Update npm dependencies Dec 4, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 08:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 15:05 Destroyed
Copy link

github-actions bot commented Dec 5, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 23:02 Destroyed
Copy link

github-actions bot commented Dec 5, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2024 08:42 Destroyed
* Updated chokidar to 4.0.1
* Updated stylelint 15.11.0
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2024 18:23 Destroyed
Copy link

github-actions bot commented Dec 6, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 9, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 20:11 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 11, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 15, 2024 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 15:06 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 17:14 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 16:23 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 19:37 Destroyed
Copy link

Checking composer.lock changes...

timcosgrove
timcosgrove previously approved these changes Dec 18, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 08:45 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 18:57 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-omnis

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element does not have an implicit (wrapped) <label>
    Element does not have an explicit <label>
    Element's default semantics were not overridden with role="none" or role="presentation"

@keisterj-oddball keisterj-oddball merged commit 2af7dd5 into main Dec 19, 2024
18 checks passed
@keisterj-oddball keisterj-oddball deleted the 19814-update-npm-dependencies-for-the-project-root-packagejson branch December 19, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update npm dependencies for the project root package.json
3 participants