Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure next-build uses node v18 everywhere. #19298

Closed
wants to merge 2 commits into from

Conversation

timcosgrove
Copy link
Contributor

Description

#17400

Next-Build has not been running correctly on Tugboat since Next-Build upgraded to Next.js v14, because of a node v18 requirement. This fixes that.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@timcosgrove timcosgrove requested a review from a team as a code owner September 23, 2024 18:43
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 18:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 20:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 25, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2024 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 29, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 30, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 4, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 5, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 6, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 7, 2024 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 8, 2024 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 9, 2024 08:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 10, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 11, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 12, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 13, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 14, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 15, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 16, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 17, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 18, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 19, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 15, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 20, 2024 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 21, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 22, 2024 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 23, 2024 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 24, 2024 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 25, 2024 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 26, 2024 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 27, 2024 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 28, 2024 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2024 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 30, 2024 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 31, 2024 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 1, 2025 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 2, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2025 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2025 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2025 08:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 7, 2025 08:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 8, 2025 08:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2025 01:12 Destroyed
Copy link

github-actions bot commented Jan 9, 2025

Checking composer.lock changes...

@timcosgrove
Copy link
Contributor Author

Closing in favor of #20132

@timcosgrove timcosgrove closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants