Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "VACMS-16853: next build branches ftw (#17154)" (#17261) #17285

Closed
wants to merge 15 commits into from

Conversation

alexfinnarn
Copy link
Contributor

@alexfinnarn alexfinnarn commented Feb 19, 2024

Description

closes #16853

Testing done

  • Updated some tests for git information/API/frontend.
  • Manually tested locally by running script.
  • Tested on Tugboat

QA steps

  1. Log in and go to "/admin/content/deploy/next"
    • Confirm you can select versions of next-build and vets-website from git references
    • Confirm there is no build in progress
    • No request or lock files should exist
    • The versions for next-build and vets-website should be "__default"
  2. Submit the form with two branches chosen for next-build and vets-website
    • Confirm that a build request file exists.
    • No build should have started yet so no lock file should exist.
    • The versions for next-build and vets-website should be reported as what you selected.
  3. Refresh the page a few times until the background process kicks off from reading the build request file.
    • Confirm that the form fields are locked during the build.
    • Confirm you can view the build log file and it is adding data until the build finishes.
  4. Refresh the form page after the build is complete
    • Confirm the disabled fields are no longer disabled.
    • View the log to see that the build finished. It might have an error, but that will be addressed in future tickets.
  5. Navigate to "/admin/content/deploy"
    • Confirm that the vets-website version is not the same as the one you chose on "/admin/content/deploy/next".

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 19, 2024 18:14 Destroyed
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting language changes in here.

Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 20, 2024 18:57 Destroyed
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 20, 2024 18:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 20, 2024 21:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 20, 2024 22:10 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 15:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 15:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 15:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 20:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 21:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 21:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 21, 2024 23:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 22, 2024 00:09 Destroyed
@alexfinnarn
Copy link
Contributor Author

reopen to kick Tugboat

@alexfinnarn alexfinnarn reopened this Feb 22, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 22, 2024 20:57 Destroyed
@alexfinnarn alexfinnarn marked this pull request as ready for review February 23, 2024 14:55
@alexfinnarn alexfinnarn requested review from a team as code owners February 23, 2024 14:55
@github-actions github-actions bot added Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops labels Feb 23, 2024
Copy link
Contributor

@tjheffner tjheffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor quibble about language in the readme, but QA steps check out, and a different version of vets-website is used for the existing content release form and the new content/deploy/next form.

Two things I notice --
The link to the last build log disappears once the build has completed, I think it would be worthwhile to display a link to the log file if it has been built prior, even if a build is not currently in progress.
Screenshot 2024-02-23 at 10 46 50 AM

Also we get new vets-website branch, but we don't actually use the assets from it because we aren't rebuilding/pulling. I don't think that's a blocker for this ticket, can be addressed as part of #17209.

Overall, great work.

Noting this cannot be merged until the next-build and vets-website-for-next-build repos are added as part of the BRD process, otherwise staging will break again.

@@ -144,6 +143,34 @@ The Tugboat and local development versions of the release content page do not tr

For more information on creating or releasing content from a preview environment, see [Environments](./environments.md).

### Next Build Releases

The upcoming static frontend "next-build" can be rebuilt using different versions of next-build and vets-website. It
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we aren't building the static frontend here, we are re-building the preview server provided by next-build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with whatever changes would best reflect what is happening when the form gets saved. I know @timcosgrove made updates to the language and I think I kept them all, but maybe I did not.

@alexfinnarn alexfinnarn added the DO NOT MERGE Do not merge this PR label Feb 23, 2024
@alexfinnarn
Copy link
Contributor Author

@tjheffner I added the "display a link to the log file if it has been built prior, even if a build is not currently in progress" note as an AC criterion to #17209. It shouldn't require much effort.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2024 21:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2024 18:16 Destroyed
@alexfinnarn
Copy link
Contributor Author

I am closing this for the time being so Tugboat has more resources, the last build failed anyway, and it can't be merged until https://github.com/department-of-veterans-affairs/devops/pull/14070 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops DO NOT MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next Build and Vets Website branches can be chosen on Tugboat
4 participants