-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "VACMS-16853: next build branches ftw (#17154)" (#17261) #17285
Conversation
This reverts commit dfc8eec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting language changes in here.
docroot/modules/custom/va_gov_content_release/src/Form/NextGitForm.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_content_release/src/Form/NextGitForm.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_content_release/va_gov_content_release.routing.yml
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_content_release/src/Form/NextGitForm.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
reopen to kick Tugboat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor quibble about language in the readme, but QA steps check out, and a different version of vets-website is used for the existing content release form and the new content/deploy/next
form.
Two things I notice --
The link to the last build log disappears once the build has completed, I think it would be worthwhile to display a link to the log file if it has been built prior, even if a build is not currently in progress.
Also we get new vets-website branch, but we don't actually use the assets from it because we aren't rebuilding/pulling. I don't think that's a blocker for this ticket, can be addressed as part of #17209.
Overall, great work.
Noting this cannot be merged until the next-build and vets-website-for-next-build repos are added as part of the BRD process, otherwise staging will break again.
@@ -144,6 +143,34 @@ The Tugboat and local development versions of the release content page do not tr | |||
|
|||
For more information on creating or releasing content from a preview environment, see [Environments](./environments.md). | |||
|
|||
### Next Build Releases | |||
|
|||
The upcoming static frontend "next-build" can be rebuilt using different versions of next-build and vets-website. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we aren't building the static frontend here, we are re-building the preview server provided by next-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with whatever changes would best reflect what is happening when the form gets saved. I know @timcosgrove made updates to the language and I think I kept them all, but maybe I did not.
@tjheffner I added the "display a link to the log file if it has been built prior, even if a build is not currently in progress" note as an AC criterion to #17209. It shouldn't require much effort. |
I am closing this for the time being so Tugboat has more resources, the last build failed anyway, and it can't be merged until https://github.com/department-of-veterans-affairs/devops/pull/14070 is merged. |
Description
closes #16853
Testing done
QA steps
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing