-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify default JSON:API Extras enhancers link fields globally #17266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,464 @@ | |||
diff --git a/.gitignore b/.gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this .gitignore part of the patch, is that just in the module?
also fine with a local patch here, but i think it's probably worthwhile to add it to d.o and reference it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is in the d.o. issue MR and patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues with this! Nie work!
Description
Closes #17021
Testing done
Manually tested locally and on Tugboat. Added a functional unit test.
Screenshots
QA steps
field_default_link
has a relativeurl
with a value similar to theuri
field's value.field_default_link
has an absoluteurl
with a value similar to theuri
field's value.field_default_link
has a relativeurl
with a value similar to theuri
field's value.Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing