Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16615 Bump drupal/entity_field_fetch from 1.0.4 to 1.0.5 #16730

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 5, 2024

Relates to #16615
Bumps drupal/entity_field_fetch from 1.0.4 to 1.0.5.

QA steps

As an admin

  1. Visit https://pr16730-xxpf67p3vml7xalnmivpkchbi2qmxmwj.ci.cms.va.gov/jsonapi/node/vamc_system_billing_insurance/cbeb033f-c091-4aba-8814-642ae0d389d9?resourceVersion=id%3A657971

    • validate that all field_cc_* fields have the fetched property
  2. Visit https://pr16730-xxpf67p3vml7xalnmivpkchbi2qmxmwj.ci.cms.va.gov/graphql/explorer

  3. Paste in

query MyQuery {
  nodeQuery(limit: 1, filter: {
      conditions: [
        { field: "status", value: ["1"], enabled: true },
        { field: "nid", value: ["42275"]},
        { field: "type", value: ["vamc_system_billing_insurance"] }
      ]
    }) {
    entities {
      ... on NodeVamcSystemBillingInsurance {
        title,
        nid
        uuid
        fieldCcAboveTopOfPage {
          fetched
          fetchedBundle
          targetField
          targetId
          targetType
          value
        }
      }
    }
  }
}

and play the query

  • validate that fieldCcAboveTopOfPage is populated with the fetched data.
  1. Wait for the FE web to build.
  2. Visit https://web-xxpf67p3vml7xalnmivpkchbi2qmxmwj.ci.cms.va.gov/va-police/
  • validate that following 3 fetched centralized content appears

image

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Dependabot: : Pull requests that update a dependency file php Dependabot pull requests that update Php code labels Jan 5, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 5, 2024 22:32 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@dependabot dependabot bot force-pushed the dependabot/composer/drupal/entity_field_fetch-1.0.5 branch from 70ba7ab to 962246d Compare January 6, 2024 01:45
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 6, 2024 01:47 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 6, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 7, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@swirtSJW swirtSJW changed the title Bump drupal/entity_field_fetch from 1.0.4 to 1.0.5 VACMS-16615 Bump drupal/entity_field_fetch from 1.0.4 to 1.0.5 Jan 8, 2024
@timcosgrove
Copy link
Contributor

Currently all field_cc* fields are returning the same values, which is not correct.

     "field_cc_above_top_of_page": {
        "target_type": "paragraph",
        "target_id": "82293",
        "target_field": null,
        "fetched_bundle": "wysiwyg",
        "fetched": {
          "field_wysiwyg": [
            {
              "value": "<h2 id=\"pay-online-by-phoneor-mail\">Pay online, by phone,&nbsp;or mail</h2>\r\n\r\n<p>Find out how to make a payment—and what to do if you're having trouble making payments or you disagree with your bill.</p>\r\n\r\n<p><a class=\"vads-c-action-link--blue\" href=\"https://www.va.gov/health-care/pay-copay-bill/\" hreflang=\"en\">Pay online, by phone, or by mail</a></p>\r\n\r\n<h2 id=\"pay-in-person\">Pay in person</h2>\r\n\r\n<p>To pay your copay bill in person, visit the agent cashier's office.</p>\r\n\r\n<p>Please bring your payment stub, along with a check or money order made payable to \"VA.\" Be sure to include your VA account number on the check or money order.</p>\r\n",
              "format": "rich_text",
              "processed": "<h2 id=\"pay-online-by-phoneor-mail\">Pay online, by phone, or mail</h2>\n\n<p>Find out how to make a payment—and what to do if you're having trouble making payments or you disagree with your bill.</p>\n\n<p><a class=\"vads-c-action-link--blue\" href=\"https://www.va.gov/health-care/pay-copay-bill/\" hreflang=\"en\">Pay online, by phone, or by mail</a></p>\n\n<h2 id=\"pay-in-person\">Pay in person</h2>\n\n<p>To pay your copay bill in person, visit the agent cashier's office.</p>\n\n<p>Please bring your payment stub, along with a check or money order made payable to \"VA.\" Be sure to include your VA account number on the check or money order.</p>"
            }
          ]
        }
      },
      "field_cc_bottom_of_page_content": {
        "target_type": "paragraph",
        "target_id": "82293",
        "target_field": null,
        "fetched_bundle": "wysiwyg",
        "fetched": {
          "field_wysiwyg": [
            {
              "value": "<h2 id=\"pay-online-by-phoneor-mail\">Pay online, by phone,&nbsp;or mail</h2>\r\n\r\n<p>Find out how to make a payment—and what to do if you're having trouble making payments or you disagree with your bill.</p>\r\n\r\n<p><a class=\"vads-c-action-link--blue\" href=\"https://www.va.gov/health-care/pay-copay-bill/\" hreflang=\"en\">Pay online, by phone, or by mail</a></p>\r\n\r\n<h2 id=\"pay-in-person\">Pay in person</h2>\r\n\r\n<p>To pay your copay bill in person, visit the agent cashier's office.</p>\r\n\r\n<p>Please bring your payment stub, along with a check or money order made payable to \"VA.\" Be sure to include your VA account number on the check or money order.</p>\r\n",
              "format": "rich_text",
              "processed": "<h2 id=\"pay-online-by-phoneor-mail\">Pay online, by phone, or mail</h2>\n\n<p>Find out how to make a payment—and what to do if you're having trouble making payments or you disagree with your bill.</p>\n\n<p><a class=\"vads-c-action-link--blue\" href=\"https://www.va.gov/health-care/pay-copay-bill/\" hreflang=\"en\">Pay online, by phone, or by mail</a></p>\n\n<h2 id=\"pay-in-person\">Pay in person</h2>\n\n<p>To pay your copay bill in person, visit the agent cashier's office.</p>\n\n<p>Please bring your payment stub, along with a check or money order made payable to \"VA.\" Be sure to include your VA account number on the check or money order.</p>"
            }
          ]
        }
      },
// <snip>; following two fields also return the same values.

@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 8, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
Bumps drupal/entity_field_fetch from 1.0.4 to 1.0.5.

---
updated-dependencies:
- dependency-name: drupal/entity_field_fetch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/composer/drupal/entity_field_fetch-1.0.5 branch from 962246d to 738055a Compare January 9, 2024 01:10
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 01:11 Destroyed
@swirtSJW
Copy link
Contributor

swirtSJW commented Jan 9, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 9, 2024

Superseded by #16776.

@dependabot dependabot bot closed this Jan 9, 2024
@dependabot dependabot bot deleted the dependabot/composer/drupal/entity_field_fetch-1.0.5 branch January 9, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependabot: : Pull requests that update a dependency file php Dependabot pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants