Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14955: Hide ief_reference_save button for CLP #16585

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Dec 29, 2023

Description

Relates to #14955.

QA steps

As a user with access to create Campaign Landing Pages

  1. Add a new Campaign Landing Page (/node/add/campaign_landing_page)
  2. Scroll down to 'Downloadable Resources' and open the section.
  3. Click to 'Enable this page segment'
  4. Under the 'Resources' section click the 'Add existing Downloadable resource'
  • Verify that there are now only 2 buttons: 'Select Downloadable resource' and 'Cancel'
  1. Click to 'Select Downloadable resource' and choose a file in the modal that pops up.
  • Verify that you can select a resource and it then shows up in the table.
  1. Click to 'Add existing Downloadable resource' again.
  2. Click to 'Select Downloadable resource' and choose another file.
  • Verify that a second file is added to the table.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@Becapa Becapa requested a review from dsasser December 29, 2023 21:47
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 29, 2023 21:47 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 30, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Dec 31, 2023
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 1, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 2, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 2, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 2, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 3, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 3, 2024 18:32 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 4, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 4, 2024 20:10 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 5, 2024
Copy link
Contributor Author

@Becapa Becapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsasser dsasser merged commit 3e70254 into main Jan 5, 2024
25 checks passed
@dsasser dsasser deleted the VACMS-14955-defect-campaign-landing-page-button branch January 5, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants