VACMS-16457: Update/patch entity_browser module

[edmund-dunn]

Description

Closes #16457.

This updates the entity_browser module and patches it and the entity_browser_tables module. There were breaking changes in entity_browser see https://www.drupal.org/project/entity_browser/issues/3407702 for reference.

Testing done

Tested locally. Cypress tests that failed in the dependabot PR passed locally.

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Mostly this would be considered good to go if autoated tests pass. However in light of the information on breaking changes we need each product team to review to make sure that none of their custom code is effected by those breaking changes.

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

Is this PR blocked by another PR?

• DO NOT MERGE

Does this PR need review from a Product Owner

• Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

• Yes, and it's written in issue ____ and queued for publication.
  • Merge and ping the UX writer so they are ready to publish after deployment
• Yes, but it hasn't yet been written
  • Don't merge yet -- ping the UX writer to write and queue content
• No announcement is needed for this code change.
  • Merge & carry on unburdened by announcements

[dsasser]

@edmund-dunn changes look good but there appears to be a cypress test failure.

[edmund-dunn]

@edmund-dunn changes look good but there appears to be a cypress test failure.

@dsasser that test is no longer needed. Per https://www.drupal.org/project/entity_browser/issues/3074457 that is now part of entity_browser.

[ndouglas]

This is fine to merge from my perspective once merge conflicts are resolved 🙂

[dsasser]

The patch for entity_browser is a bit weird in that it is loading entities that ostensibly should already be there. Swirt had a similar sentiment on the d.o issue.

[edmund-dunn]

@dsasser that was a good call. I was able to remove that patch. The patch on entity_borwser_tabloe to bring it in line with the changes to entity_browser seemed to have fixed our issues.

[swirtSJW]

I am happy that original patch has been removed.

QA Steps

Review instances of entity browser:

There are only 2 instances of entity_browser_table being used on Facilities products do my QA is limited to those. In the absence of actual QA steps on the PR, I am assuming that CMS team and PW team have reviewed the other instances.

• Validate that vet_center_locations_list is working as it should be
  prod on right
  

added entities successfully

Removed entities successfully

• Validate that paragraph.contact_information is working as it should be
  Prod on right
  

Added and removed phone numbers fine. Allowed number of entries still work