Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homepage email signup] Remove CMS feature toggle and related code in content-build #19888

Closed
6 of 12 tasks
randimays opened this issue Nov 15, 2024 · 5 comments
Closed
6 of 12 tasks
Assignees
Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team

Comments

@randimays
Copy link
Contributor

randimays commented Nov 15, 2024

Description

As part of #19516, we created a CMS feature toggle. When the toggle is ON, the original / current email signup form should show. When the feature toggle is OFF, the new React widget for the email signup form will show.

This ticket will be for removing the CMS feature toggle and the logic in content-build that uses it.

Engineering notes / background

Testing & QA

Scope / Impact analysis

What, if anything, could break as a result of this change?
Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

  • Functional testing:
  • Code review:
  • Design review:
  • Accessibility review:
  • Product acceptance:

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

@randimays randimays added Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team labels Nov 15, 2024
@FranECross FranECross removed the Needs refining Issue status label Nov 20, 2024
@randimays
Copy link
Contributor Author

Pulled in for Sprint 20

@randimays
Copy link
Contributor Author

randimays commented Jan 8, 2025

The PR to remove the feature toggle from the CMS was the last piece of code changes, and it was just merged. I just need to make sure it gets successfully removed from the CMS in all environments (tomorrow I believe) and do another testing pass.

@jilladams
Copy link
Contributor

(No CMS deploy today due to code freeze, so this'll go tomorrow.)

@randimays
Copy link
Contributor Author

Thanks @jilladams I was just coming here to update after I remembered that!

@randimays
Copy link
Contributor Author

The feature flag has been removed from the CMS in staging and production, and I've successfully validated that the email signup form is still working as expected in production. Closing as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area VA.gov homepage CMS managed product owned by Public Websites team
Projects
None yet
Development

No branches or pull requests

3 participants