Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VBA service location template(s) to have contact info phone numbers below address block #17566

Closed
8 tasks
davidmpickett opened this issue Mar 20, 2024 · 3 comments
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Mar 20, 2024

User Story or Problem Statement

  • If an editor selects "use the general facility number" under contact info, the main phone number should display after the location/address block per the Figma design
Tugboat FE and Drupal

Screenshot 2024-03-20 at 3 43 18 PM

Design in Figma

Screenshot 2024-03-20 at 3 54 53 PM

Useful links

Acceptance Criteria

  • Any contact info phone numbers (not appointment phone numbers) appear after the location/address block per the Figma design, including if "use the general facility number" is selected
  • Testing has confirmed with test data:
    • "use the general facility number" is selected
    • "use the general facility number" not selected
    • With contact info # present
    • Without contact info # present
  • Requires design review
  • Requires accessibility review
@davidmpickett davidmpickett added VA.gov frontend CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status Regional office CMS managed VBA product owned by the Facilities team labels Mar 20, 2024
@davidmpickett davidmpickett changed the title Update VBA template(s) to show all Service Location fields Update VBA template(s) to match design file Mar 20, 2024
@davidmpickett davidmpickett changed the title Update VBA template(s) to match design file Update VBA template(s) to have contact phone numbers below address block Mar 22, 2024
@davidmpickett davidmpickett changed the title Update VBA template(s) to have contact phone numbers below address block Update VBA service location template(s) to have contact info phone numbers below address block Mar 22, 2024
@davidmpickett
Copy link
Contributor Author

Just confirmed that the phone number is displaying in the correct position for VAMC Facility Services.
https://web-xptmfsnjoodldn85nzgkrgljqtfbz24b.ci.cms.va.gov/manchester-health-care/locations/manchester-va-medical-center/#laboratory-and-pathology

Screenshot 2024-04-03 at 1 40 22 PM

@laflannery
Copy link
Contributor

I feel like this is not an issue? This is the Portland Facility and I think everything is where it needs to be right?
image

@davidmpickett
Copy link
Contributor Author

It's likely that this was fixed by one of the many service location PRs that merged in the 2 months since I opened this. Closing as dupe.

@davidmpickett davidmpickett closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CY24-Q2 Calendar year Q2 2024 priority Facilities Facilities products (VAMC, Vet Center, etc) Regional office CMS managed VBA product owned by the Facilities team sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants