Facility address should not be displayed on FE when editor selects "Use the facility's street address"

[mmiddaugh]

Description

In Tugboat, the VAMC Top Task pages and VBA Service accordions are displaying the Facility Address when "Use Facility Address" is checked in the Service Location. This is not the desired behavior. VAMC service accordions currently have the correct behavior.

Examples from Tugboat

VAMC Top Task Page - Los Angeles

VBA Facility Service Accordion - Cleveland

VAMC Facility Service Accordion - Pittsburgh

Eng notes

In the liquid template, for the address under the "name of clinic heading": a conditional is missing to check if the "use facility street address" checkbox is checked, before printing.

Acceptance Criteria

• If "use facility street address" box is checked, do not show the street address on the front end
• If "use facility street address" box is not checked, the user will be prompted to enter a street address, which should be displayed on the front end
• Applies to these templates
  • VAMC Top Task pages (Billing and Insurance, Register for Care, Medical Records)
  • VBA Facilities -> Service accordions
  • VAMC Facilities -> Service accordions [Currently working as intended, but including to check for regression]

[davidmpickett]

By contrast, the VBA facility services on Tugboat currently are showing the Facility Address when this box is checked. See Cleveland VA Regional Benefit Office -home loans.

This is not what the Figma design shows, so would want to make sure @thejordanwood signs off on the proposed direction for both these cases.

[xiongjaneg]

Take to UX sync to discuss current behavior in VAMC (not showing address), but VBA is different.

[davidmpickett]

For reference, here is a previous ticket where the current logic was implemented #7339

[thejordanwood]

@davidmpickett I agree with the logic on the ticket you linked.

Correct logic for the "use facility street address" checkbox according to the following:

if "use facility street address" box is checked, do not show the street address on the front end - show only wing/floor/room info
if "use facility street address" box is not checked, the user will be prompted to enter a street address, which should be displayed on the front end

Additional logic would include:

If "use facility street address" box is checked and no wing/floor/room info is added, then nothing should show for this section.

[davidmpickett]

Thanks @thejordanwood! I am going to update this ticket to turn it in to a ticket to implement the desired behavior

[eselkin]

We have to modify the liquid template a bit. Not a big lift, but worthy of at least 2 points. The conditional needs a bit of restructuring and testing.

[mmiddaugh]

@jilladams @davidmpickett
@aklausmeier and I discussed this work and agree that although it needs to be addressed, it is not a launch blocker.

[davidmpickett]

@jilladams @davidmpickett @aklausmeier and I discussed this work and agree that although it needs to be addressed, it is not a launch blocker.

Thanks. I updated it's position in the launch plan and the sprint 2 draft plan to reflect this.

[eselkin]

Started to do this but then realized I can't test since data is not available from any mirror of prod yet and the SL tugboat ceased to exist after the merge.

[davidmpickett]

Confirmed on prod for VAMC top task pages

Can't confirm VBA on Prod, but seems like this was done in a partial template and should fix all service locations