-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit Pattern for Staging Review #69
Comments
Reach out to the 1010 team to pilot this for staging review. |
1010 team will meet with us Friday, 9/6 to discuss piloting this for us. |
1010 teams has asked that we provide designs of the pattern that should implemented in the 1010 form for staging review. |
During monday meeting, we talked about whether or not we should submit any code at all or if it's just guidance around how to use existing components. Team is considering a path forward and will make a decision by end of week. |
Per @humancompanion-usds, we'll need to open a PR to the design.va.gov repo with our draft content page.
We can also submit the updated figma file though it's not required. |
We need to add this page to the repo for design.va.gov |
Spent time today figuring out how to run the docs site locally and fought with Ruby a bit. Got it running, and pushed up a branch with prelim content: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/tree/authed-patterns/aw/add-prefill-pattern-page Also was able to get this running on a codespace! I thought that was kinda cool, but still have to figure out one of two other things to actually make it work as a preview url. |
@adamwhitlock1 this page may have relevant info for your PR once it's ready. |
@msbtterswrth, @ChristineRoseSteiffer and @beckyphung I have submitted the page for review in this PR: department-of-veterans-affairs/vets-design-system-documentation#3329 If yall see anything that I should add or fix let me know and I can still push to that branch before it is merged / review is done on it. |
Ticket has been opened as review link added: department-of-veterans-affairs/va.gov-team#90181 |
@adamwhitlock1 I wonder if we also need to include in our PR the removal of the prefill alert page and the prefill section on the alert page? |
User Story
As a member of the AEDP team I need to submit our pattern to the collab cycle staging review so that it can be adopted into the VA design system.
Background
Review the guidelines for the staging review point in the collab cycle.
ACs
Related Tasks
Artifacts
Staging Review Ticket
The text was updated successfully, but these errors were encountered: