Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Pattern for Staging Review #69

Closed
1 task done
Tracked by #102 ...
msbtterswrth opened this issue Aug 7, 2024 · 12 comments
Closed
1 task done
Tracked by #102 ...

Submit Pattern for Staging Review #69

msbtterswrth opened this issue Aug 7, 2024 · 12 comments
Assignees
Labels
[Pattern] Know when their information is prefilled Authenticated Experience Design Pattern

Comments

@msbtterswrth
Copy link
Collaborator

msbtterswrth commented Aug 7, 2024

User Story

As a member of the AEDP team I need to submit our pattern to the collab cycle staging review so that it can be adopted into the VA design system.

Background

Review the guidelines for the staging review point in the collab cycle.

ACs

  • Discover what we need from an engineering perspective
  • A collab cycle kickoff task has been created
  • A collab cycle Staging Review task has been created
    • a PR has been opened for design.va.gov
  • The Staging Review has been completed

Related Tasks

Preview Give feedback
  1. [Pattern] Know when their information is prefilled
    bellepx0

Artifacts
Staging Review Ticket

@msbtterswrth
Copy link
Collaborator Author

Reach out to the 1010 team to pilot this for staging review.

@msbtterswrth
Copy link
Collaborator Author

1010 team will meet with us Friday, 9/6 to discuss piloting this for us.

@msbtterswrth
Copy link
Collaborator Author

1010 teams has asked that we provide designs of the pattern that should implemented in the 1010 form for staging review.

@msbtterswrth
Copy link
Collaborator Author

During monday meeting, we talked about whether or not we should submit any code at all or if it's just guidance around how to use existing components. Team is considering a path forward and will make a decision by end of week.

@msbtterswrth
Copy link
Collaborator Author

Per @humancompanion-usds, we'll need to open a PR to the design.va.gov repo with our draft content page.

You can add draft: true to the yaml at the top of the pattern so that it is not in the navigation and use that to deploy it in design.va.gov and give the URL to the Governance team to review.

We can also submit the updated figma file though it's not required.

@msbtterswrth
Copy link
Collaborator Author

We need to add this page to the repo for design.va.gov

@adamwhitlock1
Copy link
Collaborator

Spent time today figuring out how to run the docs site locally and fought with Ruby a bit. Got it running, and pushed up a branch with prelim content: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/tree/authed-patterns/aw/add-prefill-pattern-page

Also was able to get this running on a codespace! I thought that was kinda cool, but still have to figure out one of two other things to actually make it work as a preview url.

@msbtterswrth
Copy link
Collaborator Author

@adamwhitlock1 this page may have relevant info for your PR once it's ready.

@adamwhitlock1
Copy link
Collaborator

@msbtterswrth, @ChristineRoseSteiffer and @beckyphung I have submitted the page for review in this PR:

department-of-veterans-affairs/vets-design-system-documentation#3329

If yall see anything that I should add or fix let me know and I can still push to that branch before it is merged / review is done on it.

@msbtterswrth
Copy link
Collaborator Author

PR is open, and I have scheduled the review for the 15th @ 11:30am EST.

Image

@msbtterswrth
Copy link
Collaborator Author

Ticket has been opened as review link added: department-of-veterans-affairs/va.gov-team#90181

@msbtterswrth
Copy link
Collaborator Author

@adamwhitlock1 I wonder if we also need to include in our PR the removal of the prefill alert page and the prefill section on the alert page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pattern] Know when their information is prefilled Authenticated Experience Design Pattern
Projects
None yet
Development

No branches or pull requests

4 participants