Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codeowners template #108

Merged
merged 2 commits into from
May 24, 2024
Merged

ci: add codeowners template #108

merged 2 commits into from
May 24, 2024

Conversation

sljory
Copy link
Contributor

@sljory sljory commented Apr 6, 2023

Bypassing to update codeowners, PR has been apprved but this particular repo also requires an unrelated status check to pass that is failing at the moment. The failure is not impacting and it is safe to approve the PR

Why?

An up to date and accurate codeowners file is requirement for the Github Security Standard that was enforced on January 8th 2024.
This PR has been raised by the Product Security Engineering team as no CODEOWNERS file was found in this repository. The benefit of the CODEOWNERS file is to be able to easily identify who owns this code and enables automatic peer reviewer assignment when a PR is raised.

"A CODEOWNERS file must be included within the repository and contain at least 1
Codeowner or member of the relevant codeowning team or group. The codeowner(s)
must be justifiable based on the codeowner's direct involvement in the repository" - Github Security Standard

Alternatively, this repository can be archived by making a request in #repo_lost-and-found

What you need to do (How to review)?

Currently the CODEOWNERS is blank.

  1. Please edit the file to add in the name of the codeowner(s)
  2. Merge the PR

If this PR was raised by mistake and a CODEOWNERS file is not needed, feel free to close this PR.


Further info

Guidance on the syntax is included in the github CODEOWNERS Documentation

JIRA: PSC-824

#Github-Security-Standard

Github Security Standard Documents and FAQ

@sljory sljory self-assigned this Apr 6, 2023
@sljory
Copy link
Contributor Author

sljory commented Nov 21, 2023

Codeowners is a requirement of the Github Security Standard
From January 8th, 2024 "A CODEOWNERS file must be included within the repository and contain at
least 1 Codeowner or member of the relevant codeowning team or group."

@sljory sljory requested a review from smnalex December 8, 2023 12:49
@sljory sljory requested review from a team and sansaid and removed request for a team February 6, 2024 13:36
@sljory sljory force-pushed the PSC-824/Add-Codeowners branch from f3f1041 to 619550b Compare May 1, 2024 13:19
@sljory sljory changed the title ci:add codeowners template ci: add codeowners template May 1, 2024
@sljory
Copy link
Contributor Author

sljory commented May 24, 2024

Bypassing to enable codeowners configuration to be updated. Test failure is unrelated and accepted failure

1 similar comment
@sljory
Copy link
Contributor Author

sljory commented May 24, 2024

Bypassing to enable codeowners configuration to be updated. Test failure is unrelated and accepted failure

@sljory sljory merged commit 17870e9 into master May 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants