Open PRs on known SDKs when the vectors change #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finn-block
force-pushed
the
test-vector-sync
branch
3 times, most recently
from
b88d519 to
eab9104
Compare
finn-block
requested review from
decentralgabe,
mistermoe,
phoebe-lew,
frankhinek and
amika-sq
as code owners
decentralgabe
approved these changes
Dec 21, 2023
|
All of this has been manually tested. I did not write unit tests for this. |
nitro-neal
reviewed
Dec 21, 2023
nitro-neal
reviewed
Dec 21, 2023
reports/sync.go
Outdated
| // these should be consts but the library expects a pointer to a string, which cannot be done with a const | ||
| var ( | ||
| vectorUpdatePRTitle = "update test vectors" | ||
| vectorUpdatePRBody = "some test vectors were changed or added to the sdk-development repo, so they need to be updated in this repo" |
There was a problem hiding this comment.
Suggested change
| vectorUpdatePRBody = "some test vectors were changed or added to the sdk-development repo, so they need to be updated in this repo" | |
| vectorUpdatePRBody = "Some test vectors were changed or added to the sdk-development repo, so they need to be updated in this repo. This is an automated PR that keeps the test vectors in sync from the main test-vectors location: https://github.com/TBD54566975/sdk-development/tree/main/web5-test-vectors" |
There was a problem hiding this comment.
I modified this slightly to make use of markdown links. Sample here.
finn-block
force-pushed
the
test-vector-sync
branch
from
d2cf7bc to
2357cbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause github actions to open PRs on web5-kt and web5-js when the vectors are updated in this repo. The PRs look like this.