Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outside pr comment #396

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix outside pr comment #396

merged 1 commit into from
Oct 16, 2024

Conversation

nitro-neal
Copy link
Contributor

Chad says:

Explanation:

github.event_name == 'pull_request': Checks if the event that triggered the workflow is a pull request.
github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name: Compares the repository names of the head (source) and base (target) of the pull request. If they are the same, it means the PR is from an inside account.
comment-on-pr: This input is now dynamically set to true only when the PR is from an inside account. Otherwise, it defaults to false.
This change ensures that the action will only attempt to comment on pull requests from inside accounts, avoiding permission issues or unwanted comments on PRs from outside contributors.

Copy link

TBD Spec Test Vectors Report (web5-rs)

Total Test VectorsTotal Test Cases✅ Passed❌ Failed⚠️ Skipped
185500
ℹ️ 5 out of 18 test vectors passed successfully.

❌ Missing Vectors (13)

These are test vectors without any test cases.
FeatureName
Credentialscreate
CryptoEs256ksign
CryptoEs256kverify
DidDhtcreate
DidWebresolve
PortableDidparse
PresentationExchangecreate_presentation_from_credentials
PresentationExchangeevaluate_presentation
PresentationExchangeselect_credentials
PresentationExchangevalidate_definition
PresentationExchangevalidate_submission
VcJwtdecode
VcJwtverify

Automatically generated at: 2024-10-16T18:06:47.674Z

Copy link
Contributor

@leordev leordev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work Chad!!!

@nitro-neal nitro-neal merged commit 5237b0e into main Oct 16, 2024
21 checks passed
@nitro-neal nitro-neal deleted the fix-outside-pr-comment branch October 16, 2024 18:08
Copy link

TBD Spec Test Vectors Report (web5-core-kt)

Total Test VectorsTotal Test Cases✅ Passed❌ Failed⚠️ Skipped
183300
ℹ️ 3 out of 18 test vectors passed successfully.

❌ Missing Vectors (15)

These are test vectors without any test cases.
FeatureName
Credentialscreate
Credentialsverify
CryptoEs256ksign
CryptoEs256kverify
DidDhtcreate
DidDhtresolve
DidWebresolve
PortableDidparse
PresentationExchangecreate_presentation_from_credentials
PresentationExchangeevaluate_presentation
PresentationExchangeselect_credentials
PresentationExchangevalidate_definition
PresentationExchangevalidate_submission
VcJwtdecode
VcJwtverify

Automatically generated at: 2024-10-16T18:10:45.652Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants