feat: Caution section on code generation #42
Conversation
|
Hello @nkkko I think this should fix how the caution section renders. |
|
@mobley-trent I'm on it |
|
hi @mojafa is the PR satisfactory ? |
|
@mobley-trent I’ve updated main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward. |
mobley-trent
force-pushed
the
caution-section
branch
from
21cc0eb to
a0b5649
Compare
|
@mojafa I've rebased the branch on top of |
|
@mobley-trent please share a screenshot of your solution. |
|
or screen recording |
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
mobley-trent
force-pushed
the
caution-section
branch
from
a0b5649 to
5171885
Compare
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
mobley-trent
force-pushed
the
caution-section
branch
from
3da1a1f to
4a3240e
Compare
|
@mojafa I added the caution section to the error div as well so that you can see how it looks.
|
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
|
@mobley-trent good one. It works now. Just a slight request, please put the warning display before the generated devcontainer? |
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
|
@mojafa done |
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
|
@nkkko please review this. Meets the requirements of the issue 
|
Signed-off-by: Eddy Oyieko <oyieko99@gmail.com>
|
added a margin between the caution div and code section |
|
@mobley-trent thanks. |
Closes #19
/claim #19