Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-compose): add Docker Compose file generation #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

onyedikachi-david
Copy link

/claim #25
Fixes: #25

Docker Compose Generation Feature

This PR adds the ability to generate Docker Compose files alongside DevContainer configurations.

Changes

  • Extended DevContainerModel in schemas.py to include Docker Compose configuration
  • Updated generate_devcontainer_json function in helpers/devcontainer_helpers.py to handle Docker Compose generation
  • Modified /generate endpoint in main.py to return both devcontainer.json and docker-compose.yml
  • Added validation for docker-compose.yml file
  • Updated prompt template to include instructions for Docker Compose generation

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@onyedikachi-david onyedikachi-david force-pushed the feature/docker-compose-generation branch from cad3123 to 5fbbc5f Compare October 10, 2024 13:43
@nkkko
Copy link
Member

nkkko commented Oct 10, 2024

@onyedikachi-david thanks, have you tested this, I get this error:
image

Where do you handle validation for docker-compose.yml file?

Also please could you please implement toggle selector "With Docker Compose":
image

@nkkko
Copy link
Member

nkkko commented Nov 5, 2024

@onyedikachi-david any updates?

@onyedikachi-david
Copy link
Author

@onyedikachi-david any updates?

I'll making a push today.

@onyedikachi-david
Copy link
Author

@nkkko please check if it works on your end. Thanks.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@mojafa
Copy link
Contributor

mojafa commented Dec 11, 2024

@onyedikachi-david I’ve updated main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward.

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

@onyedikachi-david getting this error.

Do run and test on your end as well.
Screenshot 2024-12-18 at 00 20 17
Screenshot 2024-12-18 at 00 21 17

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

Also please share screenshots or screenrecording of your solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Generation of Docker Compose in Addition to Devcontainer
3 participants