EE-123 error exchange adapters failed to update exchange rate

exchange/adapters/__init__.py

@@ -35,27 +35,34 @@ def update(self):
 
         updates = []
         inserts = []
-        currencies = list(Currency.objects.all())
+        currencies = list(Currency.objects.filter(active=True))
         for source in currencies:
             for target in currencies:
-                rate = self._get_rate_through_usd(source.code,
-                                                  target.code,
-                                                  usd_exchange_rates)
-
-                exchange_rate = ExchangeRate(source=source,
-                                             target=target,
-                                             rate=rate)
-
-                if (source.code, target.code) in existing:
-                    exchange_rate.id = existing[(source.code, target.code)]
-                    updates.append(exchange_rate)
-                    logger.debug('exchange rate updated %s/%s=%s'
-                                 % (source, target, rate))
-                else:
-                    inserts.append(exchange_rate)
-                    logger.debug('exchange rate created %s/%s=%s'
-                                 % (source, target, rate))
-
+                try:
+                    rate = self._get_rate_through_usd(source.code,
+                                                    target.code,
+                                                    usd_exchange_rates)
+
+                    exchange_rate = ExchangeRate(source=source,
+                                                target=target,
+                                                rate=rate)
+
+                    if (source.code, target.code) in existing:
+                        exchange_rate.id = existing[(source.code, target.code)]
+                        updates.append(exchange_rate)
+                        logger.debug('exchange rate updated %s/%s=%s'
+                                    % (source, target, rate))
+                    else:
+                        inserts.append(exchange_rate)
+                        logger.debug('exchange rate created %s/%s=%s'
+                                    % (source, target, rate))
+                except KeyError as e:
+                    logger.exception('Failed to update exchange rate %s/%s.' % (source.code, target.code))
+                    continue
+                except Exception as e:
+                    logger.exception(e)
+                    continue
+
             logger.info('exchange rates updated for %s' % source.code)
         logger.info("Updating %s rows" % len(updates))
         update_many(updates)

exchange/admin.py

@@ -1,5 +1,5 @@
 from django.contrib import admin
-from models import Currency, ExchangeRate
+from .models import Currency, ExchangeRate
 
 admin.site.register(Currency)
 admin.site.register(ExchangeRate)

exchange/cache.py

@@ -1,4 +1,4 @@
-from django.core.cache import get_cache
+from django.core.cache import cache
 from django.conf import settings
 
 from exchange.models import ExchangeRate
@@ -20,8 +20,12 @@
 
 CACHE_TIMEOUT = 0  # Not configurable at all
 
-cache = get_cache(CACHE_DATABASE)
-
+CACHES = {
+    'default': {
+        'BACKEND': 'django.core.cache.backends.filebased.FileBasedCache',
+        'LOCATION': CACHE_DATABASE,
+    }
+}
 
 def _get_cache_key(source_currency, target_currency):
     return ':'.join([CACHE_KEY_PREFIX, source_currency, target_currency])

exchange/migrations/0001_initial.py

@@ -1,53 +1,41 @@
 # -*- coding: utf-8 -*-
-import datetime
-from south.db import db
-from south.v2 import SchemaMigration
-from django.db import models
-
-
-class Migration(SchemaMigration):
-
-    def forwards(self, orm):
-        # Adding model 'Currency'
-        db.create_table(u'exchange_currency', (
-            (u'id', self.gf('django.db.models.fields.AutoField')(primary_key=True)),
-            ('code', self.gf('django.db.models.fields.CharField')(unique=True, max_length=3)),
-            ('name', self.gf('django.db.models.fields.CharField')(max_length=64)),
-        ))
-        db.send_create_signal(u'exchange', ['Currency'])
-
-        # Adding model 'ExchangeRate'
-        db.create_table(u'exchange_exchangerate', (
-            (u'id', self.gf('django.db.models.fields.AutoField')(primary_key=True)),
-            ('source', self.gf('django.db.models.fields.related.ForeignKey')(related_name='rates', to=orm['exchange.Currency'])),
-            ('target', self.gf('django.db.models.fields.related.ForeignKey')(to=orm['exchange.Currency'])),
-            ('rate', self.gf('django.db.models.fields.DecimalField')(max_digits=12, decimal_places=2)),
-        ))
-        db.send_create_signal(u'exchange', ['ExchangeRate'])
-
-
-    def backwards(self, orm):
-        # Deleting model 'Currency'
-        db.delete_table(u'exchange_currency')
-
-        # Deleting model 'ExchangeRate'
-        db.delete_table(u'exchange_exchangerate')
-
-
-    models = {
-        u'exchange.currency': {
-            'Meta': {'object_name': 'Currency'},
-            'code': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '3'}),
-            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
-            'name': ('django.db.models.fields.CharField', [], {'max_length': '64'})
-        },
-        u'exchange.exchangerate': {
-            'Meta': {'object_name': 'ExchangeRate'},
-            u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
-            'rate': ('django.db.models.fields.DecimalField', [], {'max_digits': '12', 'decimal_places': '2'}),
-            'source': ('django.db.models.fields.related.ForeignKey', [], {'related_name': "'rates'", 'to': u"orm['exchange.Currency']"}),
-            'target': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['exchange.Currency']"})
-        }
-    }
-
-    complete_apps = ['exchange']
+# Generated by Django 1.11.20 on 2019-09-17 17:05
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    initial = True
+
+    dependencies = [
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='Currency',
+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False)),
+                ('code', models.CharField(max_length=3, unique=True)),
+                ('name', models.CharField(max_length=64)),
+            ],
+            options={
+                'verbose_name_plural': 'currencies',
+            },
+        ),
+        migrations.CreateModel(
+            name='ExchangeRate',
+            fields=[
+                ('id', models.AutoField(auto_created=True,
+                                        primary_key=True, serialize=False)),
+                ('rate', models.DecimalField(decimal_places=8, max_digits=17)),
+                ('source', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE,
+                                             related_name='rates', to='exchange.Currency')),
+                ('target', models.ForeignKey(
+                    on_delete=django.db.models.deletion.CASCADE, to='exchange.Currency')),
+            ],
+        ),
+    ]

exchange/migrations/0002_auto_20191107_1532.py

@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.11.20 on 2019-11-07 15:32
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('exchange', '0001_initial'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='exchangerate',
+            name='rate',
+            field=models.DecimalField(decimal_places=8, max_digits=19),
+        ),
+    ]

exchange/migrations/0003_auto_20200122_2156.py

@@ -0,0 +1,26 @@
+# Generated by Django 2.2 on 2020-01-22 21:56
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('exchange', '0002_auto_20191107_1532'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='exchangerate',
+            name='source',
+            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.CASCADE,
+                                    related_name='rates', to='exchange.Currency'),
+        ),
+        migrations.AlterField(
+            model_name='exchangerate',
+            name='target',
+            field=models.ForeignKey(
+                null=True, on_delete=django.db.models.deletion.CASCADE, to='exchange.Currency'),
+        ),
+    ]

exchange/migrations/0004_currency_active.py

@@ -0,0 +1,18 @@
+# Generated by Django 2.2.24 on 2022-02-23 22:11
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('exchange', '0003_auto_20200122_2156'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='currency',
+            name='active',
+            field=models.BooleanField(default=True),
+        ),
+    ]

exchange/migrations/0005_auto_20220224_2220.py

@@ -0,0 +1,24 @@
+# Generated by Django 2.2.24 on 2022-02-24 22:20
+
+from django.db import migrations
+
+def commit_old_currencies_deactivation(apps, schema_editor):
+    Currency = apps.get_model("exchange", "Currency")
+    db_alias = schema_editor.connection.alias
+    Currency.objects.using(db_alias).filter(code__in=["MRO", "VEF"]).update(active=False)
+
+
+def rollback_old_currencies_deactivation(apps, schema_editor):
+    Currency = apps.get_model("exchange", "Currency")
+    db_alias = schema_editor.connection.alias
+    Currency.objects.using(db_alias).filter(code__in=["MRO", "VEF"]).update(active=True)
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('exchange', '0004_currency_active'),
+    ]
+
+    operations = [
+        migrations.RunPython(commit_old_currencies_deactivation, rollback_old_currencies_deactivation),
+    ]

exchange/models.py

@@ -7,6 +7,7 @@ class Currency(models.Model):
     """Model holds a currency information for a nationality"""
     code = models.CharField(max_length=3, unique=True)
     name = models.CharField(max_length=64)
+    active = models.BooleanField(default=True, help_text='Denotes whether or not the currency its being used and should update the exchange rates.')
 
     class Meta:
         verbose_name_plural = 'currencies'
@@ -20,9 +21,9 @@ def get_numeric_code(self):
 
 class ExchangeRate(models.Model):
     """Model to persist exchange rates between currencies"""
-    source = models.ForeignKey('exchange.Currency', related_name='rates')
-    target = models.ForeignKey('exchange.Currency')
-    rate = models.DecimalField(max_digits=17, decimal_places=8)
+    source = models.ForeignKey('exchange.Currency', related_name='rates', null=True, on_delete=models.CASCADE)
+    target = models.ForeignKey('exchange.Currency', null=True, on_delete=models.CASCADE)
+    rate = models.DecimalField(max_digits=19, decimal_places=8)
 
     objects = ExchangeRateManager()
 

exchange/utils.py

@@ -17,11 +17,11 @@ def import_class(class_path):
     'OrderedDict'
     """
     try:
-        from django.utils.importlib import import_module
+        from importlib import import_module
         module_name = '.'.join(class_path.split(".")[:-1])
         mod = import_module(module_name)
         return getattr(mod, class_path.split(".")[-1])
-    except Exception, detail:
+    except Exception as detail:
         raise ImportError(detail)
 
 
@@ -54,7 +54,6 @@ def insert_many(objects, using="default"):
     placeholders = ",".join(("%s",) * len(fields))
     con.cursor().executemany("insert into %s (%s) values (%s)"
                              % (table, column_names, placeholders), parameters)
-    transaction.commit_unless_managed(using=using)
 
 
 def update_many(objects, fields=[], using="default"):
@@ -86,7 +85,7 @@ def update_many(objects, fields=[], using="default"):
     parameters = []
     for o in objects:
         parameters.append(tuple(f.get_db_prep_save(f.pre_save(o, True),
-                          connection=con) for f in fields_with_pk))
+                                                   connection=con) for f in fields_with_pk))
 
     table = meta.db_table
     assignments = ",".join(("%s=%%s" % con.ops.quote_name(f.column))
@@ -95,7 +94,6 @@ def update_many(objects, fields=[], using="default"):
                              % (table, assignments,
                                 con.ops.quote_name(meta.pk.column)),
                              parameters)
-    transaction.commit_unless_managed(using=using)
 
 
 def memoize(ttl=None):