Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow lambda ARN to be used for deployment hooks #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AkiraJ48
Copy link

@AkiraJ48 AkiraJ48 commented Apr 6, 2022

Proposed changes

Currently you cannot specify an ARN for the deployment hooks preTrafficHook and postTrafficHook. The deployment hooks only expect a resource name that should exist within the cloudformation stack.

This change will allow us to have a single global lambda that will be invoked by code deploy instead of needing a lambda per cloudformation stack.

Types of changes

What types of changes does your code introduce to the plugin?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I opted for a relatively simple check on whether the given input is an ARN. Happy to introduce something like @aws-sdk/util-arn-parser instead if that's preferable.

@AkiraJ48
Copy link
Author

Hi @davidgf, when you have time could you please take a look at this PR 😄 ?

@AkiraJ48
Copy link
Author

Hi @davidgf sorry for bothering you, have you had some time to look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant