CNDB-12041: Add missing check of guardrail sai_sstable_indexes_per_query

[adelapena]

Adds the missing check call to the sai_sstable_indexes_per_query guardrail.

GuardrailNonPartitionRestrictedQueryTest was failing because of this.

I have added a temporary commit replacing the usage of bigint by int in the test so we can avoid the encoding error while we validate the guardrail. We shouldn't merge that change.

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits

[adelapena]

CC @djatnieks

[djatnieks]

I saw this error in the first PR build, so I restarted it again:

java.io.IOException: Cannot resume build -- was not cleanly saved when Jenkins shut down.
--
  | 73255 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.onLoad(CpsFlowExecution.java:824)
  | 73256 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.job.WorkflowRun.getExecution(WorkflowRun.java:719)
  | 73257 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:577)
  | 73258 | 11:33:17 AM | at hudson.model.RunMap.retrieve(RunMap.java:273)
more_vert | 73259 | 11:33:17 AM | at hudson.model.RunMap.retrieve(RunMap.java:65)
  | 73260 | 11:33:17 AM | at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:703)
  | 73261 | 11:33:17 AM | at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:685)
  | 73262 | 11:33:17 AM | at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:579)
  | 73263 | 11:33:17 AM | at hudson.model.RunMap.getById(RunMap.java:237)
  | 73264 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.run(WorkflowRun.java:968)
  | 73265 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.get(WorkflowRun.java:980)
  | 73266 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.flow.FlowExecutionList.resume(FlowExecutionList.java:226)
  | 73267 | 11:33:17 AM | at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl.onLoaded(FlowExecutionList.java:217)
  | 73268 | 11:33:17 AM | at jenkins.model.Jenkins.<init>(Jenkins.java:1051)
  | 73269 | 11:33:17 AM | at hudson.model.Hudson.<init>(Hudson.java:86)
  | 73270 | 11:33:17 AM | at hudson.model.Hudson.<init>(Hudson.java:82)
  | 73271 | 11:33:17 AM | at hudson.WebAppMain$3.run(WebAppMain.java:248)
  | 73272 | 11:33:21 AM | ERROR: Failed to load program
  | 73273 | 11:33:21 AM | Finished: FAILURE

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1501 rejected by Butler

---

60 new test failure(s) in 1 builds
See build details here

---

Found 60 new test failures

Showing only first 15 new test failures

Test	Explanation	Branch history	Upstream history
t.TestCqlshUnicode.test_unicode_identifier	regression	🔴
t.TestCqlshUnicode.test_unicode_multiline_input	regression	🔴
o.a.c.d.c.CompactionControllerTest.testMemtable...	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC40	regression	🔴
...adCommitLogAndSSTablesWithDroppedColumnTestCC50	regression	🔴
...ersionTest.v4ConnectionCleansUpThreadLocalState	regression	🔴
...d.t.QueriesTableTest.shouldExposeReadsAndWrites	regression	🔴
...eadSizeWarningTest.warnThresholdSinglePartition	regression	🔴
o.a.c.i.c.CompressionMetadataTest.testMemoryIsF...	regression	🔴
...ientRequestMetricsLatenciesTest.testReadMetrics	regression	🔴
...entRequestMetricsLatenciesTest.testWriteMetrics	regression	🔴
...ntIrWithPreviewFuzzTest.concurrentIrWithPreview	regression	🔴
o.a.c.t.SSTablePartitionsTest.testBackups	regression	🔴
o.a.c.t.SSTablePartitionsTest.testCurrentTimestamp	regression	🔴
o.a.c.t.SSTablePartitionsTest.testExcludedKeys	regression	🔴

---

No known test failures found

[djatnieks]

With these changes GuardrailNonPartitionRestrictedQueryTest passes when run locally.

[djatnieks]

I think the changes are good, but the build seems stuck, so I'll cancel/restart it. I'll quickly review the results when the build finishes and then plan to merge into CNDB-12154 if that's okay with you @adelapena