Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

Improvements regarding to errors handling #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

piranna
Copy link

@piranna piranna commented Aug 21, 2013

Improvements to raise errors according to JsonRPC 2.0 format, and also some clean-ups of code

@jhuckabee
Copy link
Contributor

@piranna, while we appreciate the pull request, its not inline with the current style of the code. The code follows the generally accepted standard of "brackets everywhere".

e.g.

if(condition) {
  ..
}

instead of

if(condition)
  ...

I'd be happy to merge this pull request minus the code re-formatting.

@piranna
Copy link
Author

piranna commented Aug 21, 2013

I'm not too much on that style, but I agree with maintain the current
style. I'll review it and update the pull-request.

2013/8/21 Josh Huckabee notifications@github.com

@piranna https://github.com/piranna, while we appreciate the pull
request, its not inline with the current style of the code. The code
follows the generally accepted standard of "brackets everywhere".

e.g.

if(condition) {
..}

instead of

if(condition)
...

I'd be happy to merge this pull request minus the code re-formatting.


Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-23024174
.

"Si quieres viajar alrededor del mundo y ser invitado a hablar en un monton
de sitios diferentes, simplemente escribe un sistema operativo Unix."
– Linus Tordvals, creador del sistema operativo Linux

@piranna
Copy link
Author

piranna commented Aug 22, 2013

I fixed the brackets yesterday and also took a look for another inconsistencies. Would you be able to review it? Thanks :-)

@artob artob self-assigned this Aug 27, 2014
@artob artob removed their assignment Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants