Improve keyboard button visibility in before-we-start #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the <kbd> tags on the Ctrl key, Enter key, Cmd key all look black, or extremely dark grey. The text is also black. I don't think this is on purpose, and looking in the code there are backticks "`" which enclose the keyboard button text. Removing these backticks will hopefully allow the text to appear white, and visible on the screen.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
tobyhodges
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Thank you for this @ragamouf. I am going to merge as this makes an important improvement to the readability of the lesson.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
Auto-generated via {sandpaper}
Source : 41ada8e
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2024-01-31 13:21:20 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : ecfdca7
Branch : main
Author : Toby Hodges <tobyhodges@carpentries.org>
Time : 2024-01-31 13:19:03 +0000
Message : Merge pull request #882 from ragamouf/patch-1
Improve keyboard button visibility in before-we-start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the keyboard tags on the Ctrl key, Enter key, Cmd key all look black, or extremely dark grey. The text is also black. I don't think this is on purpose, and looking in the code there are backticks "`" which enclose the keyboard button text. Removing these backticks will hopefully allow the text to appear white, and visible on the screen.
The screenshot below shows what I see on my google chrome browser on a mac.
I checked the code below and noticed that there were no backticks around the "F1" button.
