Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix: removing repartition as it has no effect before groupby #25

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ryuta-yoshimatsu
Copy link
Member

@ryuta-yoshimatsu ryuta-yoshimatsu commented Dec 1, 2023

Removing repartition from the following code snippet:

before

score_one_model_fn = functools.partial(Forecaster.score_one_model, model=model)
res_sdf = (
    src_df.repartition(100)
    .groupby(self.conf["group_id"])
    .applyInPandas(score_one_model_fn, schema=output_schema)
)

after

score_one_model_fn = functools.partial(Forecaster.score_one_model, model=model)
res_sdf = (
    src_df.groupby(self.conf["group_id"])
    .applyInPandas(score_one_model_fn, schema=output_schema)
)

as it has no effect preceding the groupby.

@ryuta-yoshimatsu
Copy link
Member Author

ryuta-yoshimatsu commented Dec 1, 2023

Hi @dbbnicole, it seems like the DEPLOYMENT_TARGET_TOKEN_GCP has expired and we are getting the following error when running CI on PR:

Error: {"error_code":"403","message":"Invalid access token."} at IncomingMessage.<anonymous> (/home/runner/work/_actions/databricks/run-notebook/v0/dist/webpack:/typescript-action/lib/common/src/request.js:46:1) at IncomingMessage.emit (node:events:525:35) at endReadableNT (node:internal/streams/readable:1358:12) at processTicksAndRejections (node:internal/process/task_queues:83:21)

Should we generate a new token using a service principal and set it up in GitHub?

@mshtelma mshtelma merged commit e5a24de into main Dec 7, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants