Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Alex Siman <aleksandr.siman@gmail.com>
  • Loading branch information
F3Joule and siman authored Mar 22, 2024
1 parent 056cb68 commit f575b39
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pallets/domains/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ pub mod pallet {
TooManyDomainsPerAccount,
/// This domain label may contain only a-z, 0-9 and hyphen characters.
DomainContainsInvalidChar,
/// This domain name length must be greater or equal the [`Config::MinDomainLength`] limit.
/// The length of this domain name must be greater than or equal to the [`Config::MinDomainLength`] limit.
DomainIsTooShort,
/// This domain name length must be below or equal the [`Config::MaxDomainLength`] limit.
/// The length of this domain name must be less than or equal to the [`Config::MaxDomainLength`] limit.
DomainIsTooLong,
/// This domain has expired.
DomainHasExpired,
Expand Down
2 changes: 1 addition & 1 deletion pallets/space-ownership/tests/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ fn accept_pending_ownership_should_fail_if_no_pending_transfer() {
}

#[test]
fn accept_pending_ownership_should_not_allow_non_target_to_accept() {
fn accept_pending_ownership_should_not_allow_non_target_account_to_accept() {
ExtBuilder::build_with_pending_transfers().execute_with(|| {
let _m = use_static_mock();
let creator_staking_ctx = MockCreatorStaking::is_creator_active_context();
Expand Down
1 change: 0 additions & 1 deletion pallets/spaces/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,6 @@ pub mod pallet {
Self::ensure_space_limit_not_reached(&new_owner)?;
let space = Pallet::<T>::require_space(space_id)?;

// TODO: reuse copy-pasted parts of code
SpaceIdsByOwner::<T>::mutate(&space.owner, |ids| {
remove_from_bounded_vec(ids, space_id)
});
Expand Down

0 comments on commit f575b39

Please sign in to comment.