Crosshair plugin - initial canvas size fix #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirabilos
reviewed
May 7, 2023
mirabilos
reviewed
May 7, 2023
src/extras/crosshair.js
Outdated
| @@ -28,11 +28,19 @@ Dygraph.Plugins.Crosshair = (function _extras_crosshair_closure() { | |||
|
|
|||
| var crosshair = function crosshair(opt_options) { | |||
| this.canvas_ = document.createElement("canvas"); | |||
| this.updateCanvasSize(0, 0) | |||
There was a problem hiding this comment.
would 1, 1 work as well? bit afraid of hitting corner cases here
There was a problem hiding this comment.
I think size is not important until canvas is added to DOM. Moved to activate callback, where it can be set to graph actual size
|
I also have added a size change check before updating it to remove possible unnecessary layout updates and to remove a bit of a garbage on mouse movements |
|
n-gist dixit:
I think size is not important until canvas is added to DOM. Moved to
`activate` callback, where it can be set to graph actual size
Ah, good plan.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crosshair plugin creates canvas to draw its lines, but if the graph is small enough, this canvas can block interaction with other elements until you hover over a graph giving it a chance to resize. Canvas initializes with 300x150 which is default Canvas element - Wikipedia
In the example below it overlaps the '+' button preventing clicking it
To fix it I have set the size to [0,0] in plugin constructor.