Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the visibility of the reportParser field #1216

Merged
merged 8 commits into from
Nov 16, 2024
Merged

Change the visibility of the reportParser field #1216

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8316197
Change the visibility of the reportParser field:
jit3pam Nov 10, 2024
c5062c5
Merge branch 'master' into master
jit3pam Nov 10, 2024
61d3750
Merge branch 'master' into master
jit3pam Nov 12, 2024
af2ad6b
Revert "Change the visibility of the reportParser field:"
jit3pam Nov 14, 2024
4da9a7e
use getter and setters for reportParser field in ReportBuilder and ad…
jit3pam Nov 14, 2024
9113f55
fix indentation in the signatures for the new constructor in ReportBu…
jit3pam Nov 14, 2024
cd710c2
remove the second constructor
jit3pam Nov 15, 2024
485f9ff
keep only relevant lines in the unit test
jit3pam Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/masterthought/cucumber/ReportBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public class ReportBuilder {
private static final ObjectMapper mapper = new ObjectMapper();

private ReportResult reportResult;
private final ReportParser reportParser;
protected ReportParser reportParser;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use getter/setter method instead and add unit test into

cucumber-reporting/src/test/java/net/masterthought/cucumber/ReportBuilderTest.java

Line 28 in 5e084d9

class ReportBuilderTest extends ReportGenerator {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reply @damianszczepanik!
Let me try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damianszczepanik
I have made the required changes.
Please let me know if you have more suggestions.


private Configuration configuration;
private List<String> jsonFiles;
Expand Down