Skip to content

Commit

Permalink
Cleanup pom: compiler and encoding are managed via flags making maint…
Browse files Browse the repository at this point in the history
…enance easier and other plugins do use those flags too (#1167)

* [pom] Remove invalid maven.compile.encoding property

* [pom] Remove encoding from compiler plugin as covered by project encodings

* [pom] Use standard maven compiler args for source/target to remove from compiler and allow other plugins to benifit as others use those
  • Loading branch information
hazendaz authored Mar 5, 2024
1 parent 6e7ed7d commit da9e5e0
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,12 @@
<url>https://github.com/damianszczepanik/cucumber-reporting</url>

<properties>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.resourceEncoding>UTF-8</project.build.resourceEncoding>
<maven.compile.encoding>UTF-8</maven.compile.encoding>

<byte-buddy.version>1.14.12</byte-buddy.version>
<jackson.version>2.16.1</jackson.version>
Expand Down Expand Up @@ -132,11 +134,6 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.12.1</version>
<configuration>
<source>11</source>
<target>11</target>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down

0 comments on commit da9e5e0

Please sign in to comment.