[tests] Combine assertions

damianszczepanik · Mar 4, 2024 · 38f697f · 38f697f
1 parent cc74cb3
commit 38f697f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/src/test/java/net/masterthought/cucumber/ConfigurationTest.java b/src/test/java/net/masterthought/cucumber/ConfigurationTest.java
@@ -388,8 +388,7 @@ void addClassificationFiles_addsPropertyFiles() {
 
         // then
         List<String> returnedPropertiesFiles = configuration.getClassificationFiles();
-        assertThat(returnedPropertiesFiles).hasSize(2);
-        assertThat(returnedPropertiesFiles).containsExactly(
+        assertThat(returnedPropertiesFiles).hasSize(2).containsExactly(
                 ("properties-1.properties"),
                 ("properties-2.properties")
         );

diff --git a/src/test/java/net/masterthought/cucumber/ReportParserTest.java b/src/test/java/net/masterthought/cucumber/ReportParserTest.java
@@ -198,8 +198,7 @@ void parseClassificationsFiles_Populates_Two_Files() {
 
         // then
         List<Map.Entry<String, String>> returnedClassifications = configuration.getClassifications();
-        assertThat(returnedClassifications).hasSize(8);
-        assertThat(returnedClassifications)
+        assertThat(returnedClassifications).hasSize(8)
                 .contains(new AbstractMap.SimpleEntry<>("AutUiVersion", "1.25.3"), Index.atIndex(1))
                 .contains(new AbstractMap.SimpleEntry<>("firefoxVersion", "56.0"), Index.atIndex(4))
                 .contains(new AbstractMap.SimpleEntry<>("Proxy", "http=//172.22.240.68:18717"), Index.atIndex(6))
@@ -219,8 +218,7 @@ void parseClassificationsFiles_Populates_Two_Files_One_Empty() {
 
         // then
         List<Map.Entry<String, String>> returnedClassifications = configuration.getClassifications();
-        assertThat(returnedClassifications).hasSize(5);
-        assertThat(returnedClassifications)
+        assertThat(returnedClassifications).hasSize(5)
                 .contains(new AbstractMap.SimpleEntry<>("AutUiVersion", "1.25.3"), Index.atIndex(1))
                 .contains(new AbstractMap.SimpleEntry<>("firefoxVersion", "56.0"), Index.atIndex(4));
     }
@@ -237,8 +235,7 @@ void parseClassificationsFiles_Populates_Check_Content_Integrity_And_Order() {
 
         // then
         List<Map.Entry<String, String>> classifications = configuration.getClassifications();
-        assertThat(classifications).hasSize(3);
-        assertThat(classifications).containsExactly(
+        assertThat(classifications).hasSize(3).containsExactly(
                 entry("NodeJsVersion", "8.5.0"),
                 entry("Proxy", "http=//172.22.240.68:18717"),
                 entry("NpmVersion", "5.3.0")
@@ -257,8 +254,7 @@ void parseClassificationsFiles_Populates_Check_Duplicates() {
 
         // then
         List<Map.Entry<String, String>> classifications = configuration.getClassifications();
-        assertThat(classifications).hasSize(1);
-        assertThat(classifications).containsExactly(
+        assertThat(classifications).hasSize(1).containsExactly(
                 entry("BaseUrl_QA", "[Internal=https://internal.test.com, External=https://external.test.com]")
         );
     }
@@ -275,8 +271,7 @@ void parseClassificationsFiles_Populates_Check_Special_Characters() {
 
         // then
         List<Map.Entry<String, String>> classifications = configuration.getClassifications();
-        assertThat(classifications).hasSize(6);
-        assertThat(classifications).containsExactly(
+        assertThat(classifications).hasSize(6).containsExactly(
                 entry("website", "https://en.wikipedia.org/"),
                 entry("language", "English"),
                 entry("message", "Welcome to Wikipedia!"),

diff --git a/src/test/java/net/masterthought/cucumber/sorting/SortingFactoryTest.java b/src/test/java/net/masterthought/cucumber/sorting/SortingFactoryTest.java
@@ -85,8 +85,7 @@ void sortSteps_OnNATURAL_ReturnsSameList() {
         List<StepObject> stepObjects = sortingFactory.sortSteps(steps);
 
         // then
-        assertThat(stepObjects).hasSize(16);
-        assertThat(stepObjects).first().isEqualTo(steps.get(0));
+        assertThat(stepObjects).hasSize(16).first().isEqualTo(steps.get(0));
         assertThat(stepObjects).last().isEqualTo(steps.get(15));
     }
 
@@ -101,8 +100,7 @@ void sortSteps_OnALPHABETICAL_ReturnsSameList() {
 
         // then
         // TODO: as the tags are stored in TreeMap, this returns already sorted elements
-        assertThat(stepObjects).hasSize(16);
-        assertThat(stepObjects).first().isEqualTo(steps.get(0));
+        assertThat(stepObjects).hasSize(16).first().isEqualTo(steps.get(0));
         assertThat(stepObjects).last().isEqualTo(steps.get(15));
     }