Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: External dependency reduced to "engineering" submodules #115

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

samtrion
Copy link
Member

@samtrion samtrion commented Jan 7, 2024

No description provided.

@samtrion samtrion self-assigned this Jan 7, 2024
@samtrion samtrion requested review from a team and Dakraid and removed request for a team January 7, 2024 10:20
Copy link

sonarqubecloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e322e82) 14.28% compared to head (6ed6669) 14.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   14.28%   14.28%           
=======================================
  Files          14       14           
  Lines         147      147           
  Branches       14       14           
=======================================
  Hits           21       21           
  Misses        126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samtrion samtrion merged commit acc5fcd into main Jan 7, 2024
14 checks passed
@samtrion samtrion deleted the chore/reduce-dependency-to-eng branch January 7, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant