[dagster-tableau] Use Tableau translator instance in spec loader and state-backed defs #26740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-d6rypqrre-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-tableau
branch
from
f02a110 to
5fe42bb
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-tableau-asset-specs
branch
from
2721f82 to
2a268ea
Compare
maximearmstrong
force-pushed
the
maxime/move-translator-context-to-translator-props-class-tableau
branch
from
5fe42bb to
7314593
Compare
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-tableau-asset-specs
branch
from
2a268ea to
87311d7
Compare
schrockn
approved these changes
Jan 2, 2025
Base automatically changed from
maxime/move-translator-context-to-translator-props-class-tableau
to
master
January 2, 2025 19:52
maximearmstrong
force-pushed
the
maxime/use-translator-instance-in-load-tableau-asset-specs
branch
from
87311d7 to
ed6fca9
Compare
maximearmstrong
deleted the
maxime/use-translator-instance-in-load-tableau-asset-specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Same as #26734 but for Tableau.
How I Tested These Changes
BK
Changelog
[dagster-tableau]
load_tableau_asset_specsis updated to accept an instance ofDagsterTableauTranslatoror custom subclass.