-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use name instead of ID in switchOutputWorkflow Action #408
Use name instead of ID in switchOutputWorkflow Action #408
Conversation
Hey @jheimbach, thanks for your efforts. I'm not sure if we really should add this to PX. Is it something you need on PX installations, or could we move it to v5 (master branch)? |
Hey @solverat, do i have to change the target branch? |
@jheimbach nope, master is good, but you need to resolve the conflicts :( |
@solverat will do. btw. found out that the condition "outputworkflow" has the same problem, will fix it there also. |
@jheimbach btw, if you have too many issues while rebasing to the latest master - don't hesitate to create new PR instead! |
hey @jheimbach any updates on this? |
3c612c0
to
478d571
Compare
@jheimbach I've just updated your PR:
|
Thanks @jheimbach! |
The current implementation with referencing output workflows by ID in the conditional logic action breaks on export/import the form definition.
I fixed this by referencing the output workflow by name instead.