Skip to content

Commit

Permalink
refactor(devcontainer): move vscode settings into devcont config
Browse files Browse the repository at this point in the history
This allows people not using the devcontainer option for development to modify settings without fear of committing changes to repo

Closes #332
  • Loading branch information
kenibrewer committed Oct 26, 2023
1 parent afe5df3 commit 2cbb50f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
8 changes: 5 additions & 3 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// README at: https://github.com/devcontainers/templates/tree/main/src/python
{
"name": "Pycytominer Dev",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/python:0-3.11",
// Use 'postCreateCommand' to run commands after the container is created.
"postCreateCommand": "bash .devcontainer/postCreateCommand.sh",
Expand All @@ -12,8 +11,11 @@
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/usr/local/bin/python",
"python.formatting.blackPath": "/usr/local/py-utils/bin/black"
"python.testing.pytestArgs": ["tests"],
"python.testing.unittestEnabled": false,
"python.testing.pytestEnabled": true,
"python.testing.pytestPath": "${workspaceFolder}/.venv/bin/pytest",
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python"
},

// Add the IDs of extensions you want installed when the container is created.
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ dmypy.json
# Cython debug symbols
cython_debug/

# VSCode
.vscode/

# PyCharm
# JetBrains specific template is maintained in a separate JetBrains.gitignore that can
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
Expand Down
7 changes: 0 additions & 7 deletions .vscode/settings.json

This file was deleted.

0 comments on commit 2cbb50f

Please sign in to comment.