Skip to content

Commit

Permalink
[Cylon] Remove symbolic link comment mac, win and conda side effect
Browse files Browse the repository at this point in the history
Signed-off-by: Arup Sarker <arupcsedu@gmail.com>
  • Loading branch information
arupcsedu committed Jun 9, 2024
1 parent efb1653 commit 054f234
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Remove link for preventing an error
run: rm -f /usr/local/bin/2to3
#- name: Remove link for preventing an error
# run: rm -f /usr/local/bin/2to3
- name: Install dependencies
run: brew install re2 automake boost brotli c-ares ccache flatbuffers grpc llvm lz4 minio ninja openssl@1.1 protobuf rapidjson snappy thrift wget zstd miniconda
- name: Conda Init
run: conda init $(basename ${SHELL})
run: brew install re2 automake boost brotli c-ares ccache flatbuffers grpc llvm lz4 minio ninja openssl@1.1 protobuf rapidjson snappy thrift wget zstd

- name: Include $CONDA in $PATH
run: export PATH="$CONDA/condabin:$PATH"
Expand Down
4 changes: 2 additions & 2 deletions build.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ def build_cpp():
os.environ['MPI_CXX']=f"{conda_prefix}/bin/mpicxx"
logger.info(f"export mpicxx: : {os.getenv('MPI_CXX')}")
else:
if not os.path.exists(f"{conda_prefix}/lib/libarrow_python.so"):
sym_generator = f"mlink {pyarrow_location}/libarrow_python.so {conda_prefix}/lib/libarrow_python.so"
if not os.path.exists(f"{conda_prefix}\lib\libarrow_python.so"):
sym_generator = f"mklink {pyarrow_location}\libarrow_python.so {conda_prefix}\lib\libarrow_python.so"
logger.info(f"Generate Symbolic link: {sym_generator}")
res = subprocess.call(sym_generator, cwd=BUILD_DIR, shell=True)
check_status(res, "Generate Symbolic link")
Expand Down

0 comments on commit 054f234

Please sign in to comment.