MSSQL allow to define different databases for login an user #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
When a MSSQL user is created in a database other than the master database. The USER needs to created in the dedicated database, but the LOGIN needs to be created in the master database.
This is also mentioned here: #158 (comment)
This pull request adds the possibility to define an additional database, where the login object is created in.
The already existing database fields are used for the user statements.
If the newly introduced loginDatabase is not set, the database field is used for both operations as before.
Fixes #158
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
The application was built and deployed in an existing cluster. Where the User rewource was configured to use the
loginDatabase: master
anddatabaseRef
that is pointing to a Database resource.