Feat/update secrets on expected response (#79)

* feat: update secrets on expected response Signed-off-by: Ariel Septon <arielsepton@Ariels-MBP.lan> * bump version to v1.0.8 Signed-off-by: Ariel Septon <arielsepton@Ariels-MBP.lan> --------- Signed-off-by: Ariel Septon <arielsepton@Ariels-MBP.lan> Co-authored-by: Ariel Septon <arielsepton@Ariels-MBP.lan>
crossplane-contrib · Jan 3, 2025 · b88c356 · b88c356
1 parent 511cf20
commit b88c356
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/promote.yml b/.github/workflows/promote.yml
@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: "Release version (e.g. v1.0.7)"
+        description: "Release version (e.g. v1.0.8)"
         required: true
       channel:
         description: "Release channel"

diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml
@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
     inputs:
       version:
-        description: "Release version (e.g. v1.0.7)"
+        description: "Release version (e.g. v1.0.8)"
         required: true
       message:
         description: "Tag message"

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ To install `provider-http`, you have two options:
 1. Using the Crossplane CLI in a Kubernetes cluster where Crossplane is installed:
 
    ```console
-   crossplane xpkg install provider xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.7
+   crossplane xpkg install provider xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.8
    ```
 
 2. Manually creating a Provider by applying the following YAML:
@@ -20,7 +20,7 @@ To install `provider-http`, you have two options:
    metadata:
      name: provider-http
    spec:
-     package: "xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.7"
+     package: "xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.8"
    ```
 
 ## Supported Resources

diff --git a/deploy.yml b/deploy.yml
@@ -4,7 +4,7 @@ kind: Provider
 metadata:
   name: http-provider
 spec:
-  package: xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.7
+  package: xpkg.upbound.io/crossplane-contrib/provider-http:v1.0.8
   controllerConfigRef:
     name: debug-config
 

diff --git a/internal/controller/disposablerequest/disposablerequest.go b/internal/controller/disposablerequest/disposablerequest.go
@@ -234,8 +234,9 @@ func (c *external) deployAction(ctx context.Context, cr *v1alpha2.DisposableRequ
 		return err
 	}
 
-	datapatcher.ApplyResponseDataToSecrets(ctx, c.localKube, c.logger, &resource.HttpResponse, cr.Spec.ForProvider.SecretInjectionConfigs, cr)
-	if !isExpectedResponse {
+	if isExpectedResponse {
+		datapatcher.ApplyResponseDataToSecrets(ctx, c.localKube, c.logger, &resource.HttpResponse, cr.Spec.ForProvider.SecretInjectionConfigs, cr)
+	} else {
 		limit := utils.GetRollbackRetriesLimit(cr.Spec.ForProvider.RollbackRetriesLimit)
 		return utils.SetRequestResourceStatus(*resource, resource.SetStatusCode(), resource.SetLastReconcileTime(), resource.SetHeaders(), resource.SetBody(),
 			resource.SetError(errors.New(errResponseFormat+fmt.Sprint(limit))), resource.SetRequestDetails())