Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add additional package metadata #36

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Peefy
Copy link
Collaborator

@Peefy Peefy commented Mar 1, 2024

Description of your changes

Re #35

docs: add additional package metadata

I have:

Signed-off-by: peefy <xpf6677@163.com>
Copy link
Collaborator

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy requested a review from jbw976 March 1, 2024 09:51
@Peefy Peefy added the documentation Improvements or additions to documentation label Mar 1, 2024
@Peefy Peefy merged commit d0a1c53 into main Mar 1, 2024
5 of 6 checks passed
@Peefy Peefy deleted the add-additional-package-metadata branch March 1, 2024 10:00
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! you'll then want to get a release out with this so it will show up on https://marketplace.upbound.io/functions/crossplane-contrib/function-kcl

you could probably:

  • backport this PR to the release-0.2 branch
  • tag the release branch with a v0.2.1 tag
  • run CI on the release-0.2 branch to build/publish new package with v0.2.1

i'm happy to try that out for you, so in the case that something isn't set up yet on the repo i can figure that out and remove the obstacle, then it will be easier for you next time - just let me know 🙇‍♂️

@Peefy
Copy link
Collaborator Author

Peefy commented Mar 1, 2024

Surprisingly, thank you so much to the community. I will give it a try first. 😄

@jbw976
Copy link
Member

jbw976 commented Mar 6, 2024

@Peefy have you run into any problems with getting the v0.2.1 release out? anything i can help with? it would be great to get the https://marketplace.upbound.io/functions/crossplane-contrib/function-kcl/latest page updated soon 💪 🙏

@Peefy
Copy link
Collaborator Author

Peefy commented Mar 6, 2024

Hello @jbw976 Thank you for your reminder ❤️. I am currently releasing a new stable version of KCL today, and I would like to have the function-kcl updated with it. I will do my best to complete this today.

@jbw976
Copy link
Member

jbw976 commented Mar 6, 2024

awesome, that will be a great release!! let me know if i can help in any way 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants