Allow a default source to be configured via environment variable #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable function-kcl to be used as a base image for custom functions built in KCL by allowing the function input to be empty when a default source is set via environment variable. A user can build a custom function on top of function-kcl by including a directory containing a KCL module and setting the environment variable `FUNCTION_KCL_DEFAULT_SOURCE` to the module's path. Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
Peefy
reviewed
Nov 20, 2024
| @@ -21,6 +22,8 @@ import ( | |||
| "sigs.k8s.io/yaml" | |||
| ) | |||
|
|
|||
| var defaultSource = os.Getenv("FUNCTION_KCL_DEFAULT_SOURCE") | |||
There was a problem hiding this comment.
Would you be willing to explain this usage method in the README document in another PR? Thank you! 😄
There was a problem hiding this comment.
Yes, good idea. Done in #197.
|
Would you be willing to explain this usage method in the README document in another PR? I will merge this PR. Thank you! 😄 |
adamwg
added a commit
to adamwg/function-kcl
that referenced
this pull request
Nov 20, 2024
Follow-up for crossplane-contrib#196 Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Enable function-kcl to be used as a base image for custom functions built in KCL by allowing the function input to be empty when a default source is set via environment variable. A user can build a custom function on top of function-kcl by including a directory containing a KCL module and setting the environment variable
FUNCTION_KCL_DEFAULT_SOURCEto the module's path.I have: