Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Session.java. Fix TicketAuth null authextra #562

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Update Session.java. Fix TicketAuth null authextra #562

merged 2 commits into from
Nov 28, 2024

Conversation

andzejsw
Copy link
Contributor

Fix null authextra data in TicketAuth scenario.

@andzejsw
Copy link
Contributor Author

Fix for issue: #561

@om26er
Copy link
Contributor

om26er commented Nov 26, 2024

might make sense to do a similar treatment for cra auth as well

@andzejsw
Copy link
Contributor Author

might make sense to do a similar treatment for cra auth as well

It already has correct implementation of authextra.

Ekrānuzņēmums 2024-11-26 184749

@andzejsw
Copy link
Contributor Author

might make sense to do a similar treatment for cra auth as well

Oh you meant ChallengeResponseAuth. Will do it now.

om26er
om26er approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@om26er om26er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oberstet oberstet merged commit 5f13baa into crossbario:master Nov 28, 2024
1 check passed
@oberstet
Copy link
Contributor

thanks for contributing @andzejsw , and thanks for reviewing @om26er !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@om26er om26er om26er approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andzejsw @om26er @oberstet