Features #40
Merged
Features #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 27, 2024 12:18
The commit introduces a more efficient approach to handling Prometheus timers across several modules. A new function, `PrometheusTimer`, has been created in `statistics.go` that manages the creation and usage of Prometheus Timers. This function has been utilized across various modules to replace redundant and repetitive code. This change improves code maintainability and promotes a DRY (Don't Repeat Yourself) approach. Signed-off-by: Christian Roessner <c@roessner.co>
The code changes reflect a simplification in the function calls to `PrometheusTimer`. Now instead of passing `stats.FunctionDuration.WithLabelValues` which included additional metrics, the function only requires the service name and task name. This results in cleaner, more readable code without unnecessary complexity. Signed-off-by: Christian Roessner <c@roessner.co>
The callback service has been added to the server's authentication process. This addition includes setting up the authentication for the callback service as well as executing the callback in the HTTP and REST layers of the process. The callback service aims to call a generic Lua function. Future development will finalize this functionality. Signed-off-by: Christian Roessner <c@roessner.co>
Introduce the Lua callback feature in the authentication server logic. This update refactored the setupFeaturesAndFilters function to setupLuaScripts, which now also pre-compiles Lua callbacks. Additionally, the logic for executing Lua callbacks was added to the server's REST API and integrating it into configuration handling. Errors encountered are now captured and logged. Signed-off-by: Christian Roessner <c@roessner.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.