Features #184
Merged
Features #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 5, 2024 17:20
Fix various log strings in checkSMTP, checkIMAP, checkPOP3 and checkHTTP. Signed-off-by: Christian Roessner <c@roessner.co>
Revised error handling and logging across various network connection protocols, including SMTP, POP3, IMAP, and HTTP for better clarity and error propagation. Set read and write timeouts for network connections to enhance reliability. These changes improve code maintainability and error transparency, reducing reliance on external logging and ensuring errors are properly returned and handled. Signed-off-by: Christian Roessner <c@roessner.co>
…Port The methods GetBackendServerIP and GetBackendServerPort have been removed from the File struct in server/config/file.go. This change cleans up the code by eliminating unused methods, improving maintainability and readability. Signed-off-by: Christian Roessner <c@roessner.co>
Consolidated logging of server errors with formatted messages for clarity. Improved server connection handling by adding a deep check to enable more thorough protocol handling, and ensured proper response checks for SMTP authentication. Refactored Lua backend server structure for better integration with the existing backend server configuration. Signed-off-by: Christian Roessner <c@roessner.co>
Enhance the handleProtocol function to support LMTP alongside SMTP by adding a check for LMTP in the switch statement. Modify the checkSMTP function to differentiate between SMTP and LMTP by using the appropriate command (EHLO for SMTP, LHLO for LMTP). This update ensures better protocol handling and extends the server's capability to authenticate connections using the LMTP protocol. Signed-off-by: Christian Roessner <c@roessner.co>
This update introduces a verification to ensure that network connections are using TLS before proceeding with authentication. If a connection is not secured with TLS, an error is returned to reinforce security. Additionally, a new error type, ErrMissingTLS, is introduced to handle non-TLS connection scenarios. Signed-off-by: Christian Roessner <c@roessner.co>
Added TLS minimum version enforcement to improve security. Refactored the sieve response parsing to centralize logic and streamline error handling, improving maintainability and reducing redundancy. Signed-off-by: Christian Roessner <c@roessner.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.