Features #180
Merged
Features #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 3, 2024 11:08
Introduce a 'soft whitelist' feature to enhance flexibility in client IP handling. This feature applies a less strict whitelist check, allowing certain usernames and networks to bypass stricter authentication checks. Additionally, the `HandleFeatures` method was refactored to utilize the new soft whitelist checking mechanisms. Signed-off-by: Christian Roessner <c@roessner.co>
Introduced a new soft whitelist feature for network management, with corresponding Lua module bindings. This includes constants, operations for setting, retrieving, and deleting whitelist entries, and comprehensive unit tests to ensure expected behavior. The implementation provides integration across various server components, enhancing flexibility and security in network handling. Signed-off-by: Christian Roessner <c@roessner.co>
Introduced a new soft whitelist feature for network management, with corresponding Lua module bindings. This includes constants, operations for setting, retrieving, and deleting whitelist entries, and comprehensive unit tests to ensure expected behavior. The implementation provides integration across various server components, enhancing flexibility and security in network handling. Signed-off-by: Christian Roessner <c@roessner.co>
Introduce a read-write mutex in the SoftWhitelist type to ensure thread safety during concurrent operations. Locks are added to methods that read or modify the internal map, preventing race conditions. This change enhances stability by synchronizing access across multiple goroutines. Signed-off-by: Christian Roessner <c@roessner.co>
Changed the SoftWhitelist map initialization to have an initial size of 1 for performance improvement. Also updated the network retrieval to check for existence using the map's boolean return, avoiding deadlocks. Signed-off-by: Christian Roessner <c@roessner.co>
Refactored the softallow modules to define and use the SoftWhitelistProvider interface, enhancing modularity and readability. Updated the NewSoftWhitelist function to initialize an empty map without a predefined size. Adjusted LUA functions to utilize the updated SoftWhitelistProvider methods, including adding initialization checks and handling feature categories more robustly. Signed-off-by: Christian Roessner <c@roessner.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.