Features #164
Merged
Features #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 14, 2024 21:20
This commit simplifies the cache loading logic by ensuring the user account is updated in Redis before querying cache names. It introduces a check for Redis errors and ensures known user details are only processed once, improving efficiency and clarity. Signed-off-by: Christian Roessner <c@roessner.co>
Eliminated the unnecessary verification steps related to password history within the cache loading process. This streamlines the function and avoids redundant password lookups for already known wrong passwords. Signed-off-by: Christian Roessner <c@roessner.co>
Renamed the function and updated its behavior to better reflect its purpose. The new function no longer returns the passDBResult and has an updated inline comment for clarity. Removed redundant return statements in the process. Signed-off-by: Christian Roessner <c@roessner.co>
The check for `AccountField` being nil was unnecessary as the code handles the assignment condition elsewhere. This simplifies the `auth.go` file and ensures the logic is more streamlined and maintains correctness. Signed-off-by: Christian Roessner <c@roessner.co>
Ensure authentication requests respect `NoAuth` setting and prevent storage of empty passwords in Redis cache. This update refines the process of handling user database queries and enhances security by avoiding redundant password history retrievals. Signed-off-by: Christian Roessner <c@roessner.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.