Features #118
Merged
Features #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2024 09:00
Replace usage of NewHTTPClient function with NewClosingHTTPClient to ensure proper handling of idle HTTP connections. This change helps to avoid potential resource leaks by encapsulating the closing logic within a dedicated function. All impacted files have been updated accordingly to use the new client and closure pattern. Signed-off-by: Christian Roessner <c@roessner.co>
Removed redundant `defer close(channel)` statements in multiple functions across ldap.go and lua.go. Channels are no longer explicitly closed as they are garbage-collected when no longer in use. This cleanup improves code readability and ensures proper handling of channel lifecycles. Signed-off-by: Christian Roessner <c@roessner.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.