Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node js quickstart v2 #127

Merged
merged 15 commits into from
Jan 8, 2024
Merged

Node js quickstart v2 #127

merged 15 commits into from
Jan 8, 2024

Conversation

prajwal-pai77
Copy link
Contributor

No description provided.

@prajwal-pai77 prajwal-pai77 marked this pull request as ready for review December 29, 2023 06:47
Copy link

@nithishr nithishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor improvements:
Testing

  • Can you add tests for validation of the fields?
  • Negative (404) tests
  • Some additional checks in the responses (values, length, country, etc) in some cases

Double check the environment variables

__test__/api-airline-delete.test.js Show resolved Hide resolved
__test__/api-airport-list.test.js Show resolved Hide resolved
__test__/imports.js Outdated Show resolved Hide resolved
config/dev.env Show resolved Hide resolved
config/dev.env Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@prajwal-pai77 prajwal-pai77 requested a review from nithishr January 5, 2024 11:32
README.md Outdated Show resolved Hide resolved
Copy link

@nithishr nithishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you please update the Node version & merge?

@prajwal-pai77 prajwal-pai77 merged commit caf60ca into master Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants