chore: follow up for testing rest of methods on 07-tendermint light c…

…lient module (#6135)

* move tests from client state to lcm, use lcm entry point

* linter

* update Initialise test + coverage

* linter

* import naming

* update for pr review

* followup to lcm testing pr

* linter

* update: use lcm entrypoint

* update: use lcm entrypoint

* linter

* linter

* merge artifact

* add single test for panics cases

* a bit of linting a day keeps the doctor away

* more linting

* fix test

* test: fixup testing logic

* nit: use errors.New() where no args are present for formatting

---------

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>

modules/core/02-client/keeper/client_test.go

@@ -508,7 +508,9 @@ func (suite *KeeperTestSuite) TestUpdateClientEventEmission() {
 	path := ibctesting.NewPath(suite.chainA, suite.chainB)
 	path.SetupClients()
 
-	trustedHeight := path.EndpointA.GetClientState().(*ibctm.ClientState).LatestHeight
+	tmClientState, ok := path.EndpointA.GetClientState().(*ibctm.ClientState)
+	suite.Require().True(ok)
+	trustedHeight := tmClientState.LatestHeight
 	header, err := path.EndpointA.Counterparty.Chain.IBCClientHeader(path.EndpointA.Counterparty.Chain.LatestCommittedHeader, trustedHeight)
 	suite.Require().NoError(err)
 

modules/core/02-client/keeper/keeper_test.go

@@ -570,7 +570,9 @@ func (suite *KeeperTestSuite) TestIBCSoftwareUpgrade() {
 
 			path := ibctesting.NewPath(suite.chainA, suite.chainB)
 			path.SetupClients()
-			upgradedClientState = path.EndpointA.GetClientState().(*ibctm.ClientState).ZeroCustomFields()
+			tmClientState, ok := path.EndpointA.GetClientState().(*ibctm.ClientState)
+			suite.Require().True(ok)
+			upgradedClientState = tmClientState.ZeroCustomFields()
 
 			// use height 1000 to distinguish from old plan
 			plan = upgradetypes.Plan{