fix(bundle): include codecs chunks into bundle in bundle mode #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-wado-image-loader ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! I think this is fine. Looks like an oversight on our part. Multiple chunks is okay for the dynamic import version but indeed we should only have one for the bundled UMD version of the library. I'll leave it to @sedghi to merge. |
|
I will merge this, but interested to know why you are not using dynamic import one which is smaller and faster? |
sedghi
approved these changes
Mar 21, 2023
sedghi
changed the title
|
🎉 This PR is included in version 4.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
webpack:bundlescript created610.bundle.min.jsand888.bundle.min.jsfiles that caused incorrect referencing in other applications (examples: [ #511 , #479 , #439 ]).Updated webpack config to include all chunks together. Actually, this approanch helped with incorrect referencing in embedded OHIF Viewer that we're using in our app
Previous dist build:
Current dist build:
