Check cache when prefetching wadouri images for volume #1765
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using wadouri: scheme with streaming image volume loader, the first, middle and possibly last images must be cached so that the volume can be constructed from metadata. This change first checks if the required images are already in the cache before getting the loadPoolManager involved.
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using wadouri: scheme with streaming image volume loader, the first, middle and possibly last images must be cached so that the volume can be constructed from metadata. Even when the needed images are cached, it seems that re-requesting them via the loadpoolmanager takes pretty long.
Changes & Results
This change first checks if the required images are already in the cache before getting the loadPoolManager involved, and skips it if so. This will only noticeably speed up volume creation when all the needed images are already cached, for instance when converting a stack to a volume.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment