Skip to content

Commit

Permalink
patch - slo symbol_type bug fixing (#215)
Browse files Browse the repository at this point in the history
  • Loading branch information
OrNovo authored Mar 14, 2024
1 parent d1ecd8d commit cf02210
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -497,4 +497,9 @@ Breaking Changes:
## Release 1.12.0
Breaking Changes:
#### resource/coralogix_sli
* `filters` was changed from `TypeList` to `TypeSet`.
* `filters` was changed from `TypeList` to `TypeSet`.

## Release 1.12.1
Bug fixing:
#### resource/coralogix_slo
* fixing `threshold_symbol_type` bug in ac ase of `greater_or_equal` and add `less_or_equal` option.
2 changes: 1 addition & 1 deletion coralogix/resource_coralogix_slo.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var (
slos.ThresholdSymbol_THRESHOLD_SYMBOL_GREATER: "greater",
slos.ThresholdSymbol_THRESHOLD_SYMBOL_GREATER_OR_EQUAL: "greater_or_equal",
slos.ThresholdSymbol_THRESHOLD_SYMBOL_LESS: "less",
slos.ThresholdSymbol_THRESHOLD_SYMBOL_LESS_OR_EQUAL: "greater_or_equal",
slos.ThresholdSymbol_THRESHOLD_SYMBOL_LESS_OR_EQUAL: "less_or_equal",
slos.ThresholdSymbol_THRESHOLD_SYMBOL_EQUAL: "equal",
}
schemaToProtoThresholdSymbolType = ReverseMap(protoToSchemaThresholdSymbolType)
Expand Down
2 changes: 1 addition & 1 deletion docs/data-sources/slo.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ data "coralogix_slo" "example" {
- `status` (String)
- `target_percentage` (Number) Target percentage. This is the target percentage of the SLO.
- `threshold_microseconds` (Number) Threshold in microseconds. Required when `type` is `latency`.
- `threshold_symbol_type` (String) Threshold symbol type. Required when `type` is `latency`. Valid values are: ["greater" "greater_or_equal" "less" "equal"]
- `threshold_symbol_type` (String) Threshold symbol type. Required when `type` is `latency`. Valid values are: ["greater" "greater_or_equal" "less" "less_or_equal" "equal"]
- `type` (String) Type. This is the type of the SLO. Valid values are: "error", "latency".

<a id="nestedatt--filters"></a>
Expand Down
3 changes: 1 addition & 2 deletions docs/resources/slo.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ resource "coralogix_slo" "example_2" {
- `description` (String) Optional SLO description.
- `filters` (Attributes Set) (see [below for nested schema](#nestedatt--filters))
- `threshold_microseconds` (Number) Threshold in microseconds. Required when `type` is `latency`.
- `threshold_symbol_type` (String) Threshold symbol type. Required when `type` is `latency`. Valid values
are: ["greater" "greater_or_equal" "less" "equal"]
- `threshold_symbol_type` (String) Threshold symbol type. Required when `type` is `latency`. Valid values are: ["greater" "greater_or_equal" "less" "less_or_equal" "equal"]

### Read-Only

Expand Down

0 comments on commit cf02210

Please sign in to comment.