fixing flow alert test (#177)

* fixing flow alert test * patch - changing notifications_group to computed
coralogix · Nov 28, 2023 · 820d22f · 820d22f
1 parent a63ee9d
commit 820d22f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 13 deletions.
diff --git a/coralogix/resource_coralogix_alert.go b/coralogix/resource_coralogix_alert.go
@@ -265,11 +265,13 @@ func AlertSchema() map[string]*schema.Schema {
 			Description: "The expiration date of the alert (if declared).",
 		},
 		"notifications_group": {
-			Type:        schema.TypeSet,
-			Optional:    true,
-			Elem:        notificationGroupSchema(),
-			Set:         schema.HashResource(notificationGroupSchema()),
-			Description: "Defines notifications settings over list of group-by keys (or on empty list).",
+			Type:         schema.TypeSet,
+			Optional:     true,
+			Computed:     true,
+			Elem:         notificationGroupSchema(),
+			Set:          schema.HashResource(notificationGroupSchema()),
+			Description:  "Defines notifications settings over list of group-by keys (or on empty list).",
+			AtLeastOneOf: []string{"notifications_group", "show_in_insights"},
 		},
 		"payload_filters": {
 			Type:     schema.TypeSet,
@@ -306,6 +308,7 @@ func AlertSchema() map[string]*schema.Schema {
 					},
 				},
 			},
+			AtLeastOneOf: []string{"notifications_group", "show_in_insights"},
 		},
 		"scheduling": {
 			Type:     schema.TypeList,

diff --git a/coralogix/resource_coralogix_alert_test.go b/coralogix/resource_coralogix_alert_test.go
@@ -1107,6 +1107,10 @@ func testAccCoralogixResourceAlertFLow(a *flowAlertTestParams) string {
       		group_by          = ["coralogix.metadata.sdkId"]
     	}
 	}
+	show_in_insights {
+    	retriggering_period_minutes = 60
+    	notify_on                   = "Triggered_and_resolved"
+  	}
 }
 
 	resource "coralogix_alert" "test" {

diff --git a/examples/alert/main.tf b/examples/alert/main.tf
@@ -81,7 +81,7 @@ resource "coralogix_alert" "ratio_alert" {
 
   notifications_group {
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
     notification {
@@ -130,7 +130,7 @@ resource "coralogix_alert" "new_value_alert" {
 
   notifications_group {
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
     notification {
@@ -165,7 +165,7 @@ resource "coralogix_alert" "time_relative_alert" {
 
   notifications_group {
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
     notification {
@@ -201,7 +201,7 @@ resource "coralogix_alert" "metric_lucene_alert" {
 
   notifications_group {
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 60
     }
     notification {
@@ -247,7 +247,7 @@ resource "coralogix_alert" "metric_promql_alert" {
 
   notifications_group {
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
     notification {
@@ -288,7 +288,7 @@ resource "coralogix_alert" "unique_count_alert" {
   notifications_group {
     group_by_fields = ["coralogix.metadata.sdkId"]
     notification {
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
     notification {
@@ -332,7 +332,7 @@ resource "coralogix_alert" "tracing_alert" {
     }
     notification {
       notify_on                   = "Triggered_and_resolved"
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
   }
@@ -389,7 +389,7 @@ resource "coralogix_alert" "flow_alert" {
     }
     notification {
       notify_on                   = "Triggered_and_resolved"
-      integration_id              = coralogix_webhook.slack_webhook.id
+      integration_id              = coralogix_webhook.slack_webhook.external_id
       retriggering_period_minutes = 1
     }
   }